Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aspect is Wrong in Fullscreen #4986

Closed
1 task
joncameron opened this issue Nov 30, 2022 · 2 comments
Closed
1 task

Aspect is Wrong in Fullscreen #4986

joncameron opened this issue Nov 30, 2022 · 2 comments
Assignees
Labels

Comments

@joncameron
Copy link
Contributor

Description

The video in an example item is in vertical orientation. The aspect maps correctly to the player on the page, but in fullscreen it doesn't show the full dimensions of the video

Example item:
https://avalon-staging.dlib.indiana.edu/media_objects/np193916n

Expected Behavior

  • Aspect ratio is preserved when going fullscreen, in the same way it fits the dimensions of the media player within the page (letter or pillarboxed as needed)
@joncameron joncameron added the bug label Nov 30, 2022
@joncameron
Copy link
Contributor Author

See if this still persists after reverting full-screen changes for iOS.

@elynema
Copy link
Contributor

elynema commented Dec 2, 2022

Testing with a vertical orientation video on avalon-dev in Firefox and Chrome; aspect ratio was retained in full-screen.

@elynema elynema closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants