Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate communicating worker completion over IPC, rather than exit signals #1777

Closed
novemberborn opened this issue Apr 22, 2018 · 1 comment

Comments

@novemberborn
Copy link
Member

For #1722 I had to remove the job concurrency in AVA's internal tests for Windows. Tests that themselves invoked AVA in a child process would time out, since the invoked AVA instance would fail to detect its workers exited.

There's something odd going on with detecting process exits on Windows. This seemed more prevalent with Node.js 6. I'm not sure if this is a known issue.

Regardless, we should investigate whether the worker can communicate its "I'm about to exit successfully" over IPC, to increase the likelihood of AVA detecting this correctly.

See also #1718 and #1378.

@novemberborn
Copy link
Member Author

I've seen timeout behavior still on Windows, so old though this issue may be, it could still be a worthwhile change.

@novemberborn novemberborn closed this as not planned Won't fix, can't repro, duplicate, stale Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant