Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events to existing precompiles #950

Closed
ceyonur opened this issue Oct 10, 2023 · 1 comment · Fixed by #961 or #968
Closed

Add events to existing precompiles #950

ceyonur opened this issue Oct 10, 2023 · 1 comment · Fixed by #961 or #968
Assignees
Milestone

Comments

@ceyonur
Copy link
Collaborator

ceyonur commented Oct 10, 2023

We have added our first event to the Warp precompile. We can add events to rest of our default precompiles (nativeminter,feeconfigmanager etc). These events should only be emitted with DUpgrade. This issue can be splitted into smaller issues for each precompile.

@ceyonur ceyonur added this to the subnet-evm@Future Release milestone Oct 10, 2023
@ceyonur ceyonur added this to EVM Oct 10, 2023
@github-project-automation github-project-automation bot moved this to Backlog 🗄 in EVM Oct 10, 2023
@ceyonur
Copy link
Collaborator Author

ceyonur commented Oct 10, 2023

Possible events:

  • SetAllowList Events (indexed sender address, indexed modified address, indexed role, unindexed fromRole?)
    • could be specific event for each set functions (i.e setAdminEvent, setEnabledEvent) with indexed fromRole.
  • setFeeConfig: indexed sender address, unindexed resulting feeconfig?, unindexed from fee config?
  • mintNativeCoin: indexed sender address, indexed receiver address, indexed amount
  • setRewardAddress: indexed sender address, indexed reward address
  • allowFeeRecipients: indexed sender address
  • disableRewards: indexed sender address

@abi87 abi87 linked a pull request Oct 19, 2023 that will close this issue
@abi87 abi87 linked a pull request Nov 28, 2023 that will close this issue
@abi87 abi87 assigned ceyonur and unassigned abi87 Nov 28, 2023
@ceyonur ceyonur moved this from Backlog 🗄️ to In Progress 🏗 in Platform Engineering Group Dec 4, 2023
@ceyonur ceyonur moved this from In Progress 🏗 to In Review 👀 in Platform Engineering Group Dec 18, 2023
@ceyonur ceyonur modified the milestones: v0.5.10, v0.5.11 Dec 18, 2023
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in Platform Engineering Group Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Status: Backlog 🗄
2 participants