Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Test: TestUpdateGasPriceInitializesPrice #494

Closed
aaronbuchwald opened this issue Feb 6, 2023 · 2 comments
Closed

Flaky Test: TestUpdateGasPriceInitializesPrice #494

aaronbuchwald opened this issue Feb 6, 2023 · 2 comments
Assignees
@aaronbuchwald
Labels
bug Something isn't working
Milestone
subnet-evm@Future...

Comments

@aaronbuchwald
Copy link
Collaborator

Describe the bug
The following test flakes sometimes in CI: https://github.com/ava-labs/subnet-evm/actions/runs/4106650918/jobs/7085148883#step:6:55

Expected behavior
The test should pass consistently.

Screenshots
Screen Shot 2023-02-06 at 15 38 33
@aaronbuchwald aaronbuchwald added the bug Something isn't working label Feb 6, 2023
@aaronbuchwald aaronbuchwald self-assigned this Feb 16, 2023
@aaronbuchwald
Copy link
Collaborator Author

The bug is here: https://github.com/ava-labs/subnet-evm/blob/master/plugin/evm/gasprice_update_test.go#L41-L57

The attemptWait function starts a goroutine to wait for a waitgroup to finish and then close a channel. However, this creates a race condition because that goroutine may finish after the passed in ticker has already gone off to signal that the test has timed out and should fail

@aaronbuchwald aaronbuchwald mentioned this issue Feb 16, 2023
Merged
@aaronbuchwald
Copy link
Collaborator Author

Fixed by #514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronbuchwald aaronbuchwald

Labels
bug Something isn't working
Projects
None yet
Milestone
subnet-evm@Future Release
Development

No branches or pull requests
1 participant
@aaronbuchwald