-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_perception_launch): add centerpoint_vs_centerpoint-tiny launch file #2304
Conversation
This launch file is for showing centerpoint and centerpoint_tinymodels’ results simultaneously, making it easier to visualize and compare the performance. Signed-off-by: YueChuCheng <maggie9907@gmail.com>
Could you share a video or image? Also, I think it would be better to place it in the lidar_centerpoint package. |
Here is the image after launch. I have also put this image into the README file. |
Signed-off-by: YueChuCheng <maggie9907@gmail.com>
Signed-off-by: YueChuCheng <maggie9907@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YueChuCheng
Just some minor comments.
...enterpoint/launch/centerpoint_vs_centerpoint-tiny/centerpoint_vs_centerpoint-tiny.launch.xml
Outdated
Show resolved
Hide resolved
perception/lidar_centerpoint/launch/centerpoint_vs_centerpoint-tiny/README
Outdated
Show resolved
Hide resolved
Codecov ReportBase: 10.43% // Head: 10.46% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2304 +/- ##
==========================================
+ Coverage 10.43% 10.46% +0.03%
==========================================
Files 1264 1249 -15
Lines 92257 90919 -1338
Branches 21129 20728 -401
==========================================
- Hits 9624 9517 -107
+ Misses 72423 71309 -1114
+ Partials 10210 10093 -117
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: YueChuCheng <maggie9907@gmail.com>
Signed-off-by: YueChuCheng <maggie9907@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@yukke42 Could you approve this as a codeowner?
Cloud you rename README to README.md so that we can see markdown preview? |
Signed-off-by: YueChuCheng <maggie9907@gmail.com>
Sure, just rename the file. |
…unch file (autowarefoundation#2304) * Add centerpoint_vs_centerpoint-tiny launch file This launch file is for showing centerpoint and centerpoint_tinymodels’ results simultaneously, making it easier to visualize and compare the performance. Signed-off-by: YueChuCheng <maggie9907@gmail.com> * ci(pre-commit): autofix * Relocate folder from tier4_perception_launch to lidar_centerpoint. Signed-off-by: YueChuCheng <maggie9907@gmail.com> * ci(pre-commit): autofix * Correct XML format Signed-off-by: YueChuCheng <maggie9907@gmail.com> * ci(pre-commit): autofix * Remove redundant code. Add sample rosbag link provided by autoware. Signed-off-by: YueChuCheng <maggie9907@gmail.com> * Correct spelling mistake. Signed-off-by: YueChuCheng <maggie9907@gmail.com> * Rename README file Signed-off-by: YueChuCheng <maggie9907@gmail.com> Signed-off-by: YueChuCheng <maggie9907@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…unch file (autowarefoundation#2304) * Add centerpoint_vs_centerpoint-tiny launch file This launch file is for showing centerpoint and centerpoint_tinymodels’ results simultaneously, making it easier to visualize and compare the performance. Signed-off-by: YueChuCheng <maggie9907@gmail.com> * ci(pre-commit): autofix * Relocate folder from tier4_perception_launch to lidar_centerpoint. Signed-off-by: YueChuCheng <maggie9907@gmail.com> * ci(pre-commit): autofix * Correct XML format Signed-off-by: YueChuCheng <maggie9907@gmail.com> * ci(pre-commit): autofix * Remove redundant code. Add sample rosbag link provided by autoware. Signed-off-by: YueChuCheng <maggie9907@gmail.com> * Correct spelling mistake. Signed-off-by: YueChuCheng <maggie9907@gmail.com> * Rename README file Signed-off-by: YueChuCheng <maggie9907@gmail.com> Signed-off-by: YueChuCheng <maggie9907@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>
This launch file is for showing centerpoint and centerpoint_tinymodels’ results simultaneously, making it easier to visualize and compare the performance.
Signed-off-by: YueChuCheng maggie9907@gmail.com
Note: Confirm the contribution guidelines before submitting a pull request.
Click the
Preview
tab and select a PR template:Do NOT send a PR with this description.