Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_perception_launch): add centerpoint_vs_centerpoint-tiny launch file #2304

Merged
merged 10 commits into from
Dec 1, 2022

Conversation

YueChuCheng
Copy link
Contributor

This launch file is for showing centerpoint and centerpoint_tinymodels’ results simultaneously, making it easier to visualize and compare the performance.

Signed-off-by: YueChuCheng maggie9907@gmail.com

Note: Confirm the contribution guidelines before submitting a pull request.

Click the Preview tab and select a PR template:

Do NOT send a PR with this description.

This launch file is for showing centerpoint and centerpoint_tinymodels’ results simultaneously, making it easier to visualize and compare the performance.

Signed-off-by: YueChuCheng <maggie9907@gmail.com>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Nov 16, 2022
@YueChuCheng YueChuCheng changed the title feat(centerpoint_vs_centerpoint-tiny): Add centerpoint_vs_centerpoint-tiny launch file feat(centerpoint vs centerpoint-tiny): Add centerpoint_vs_centerpoint-tiny launch file Nov 16, 2022
@YueChuCheng YueChuCheng changed the title feat(centerpoint vs centerpoint-tiny): Add centerpoint_vs_centerpoint-tiny launch file feat(centerpoint vs centerpoint tiny): Add centerpoint_vs_centerpoint-tiny launch file Nov 16, 2022
@YueChuCheng YueChuCheng changed the title feat(centerpoint vs centerpoint tiny): Add centerpoint_vs_centerpoint-tiny launch file feat(tier4_perception_launch): add centerpoint_vs_centerpoint-tiny launch file Nov 16, 2022
@yukkysaito
Copy link
Contributor

Could you share a video or image? Also, I think it would be better to place it in the lidar_centerpoint package.

@YueChuCheng
Copy link
Contributor Author

YueChuCheng commented Nov 18, 2022

Could you share a video or image? Also, I think it would be better to place it in the lidar_centerpoint package.

Here is the image after launch. I have also put this image into the README file.
And I think you are right, this launch file is better placed in lidar_centerpoint. Thanks!

Signed-off-by: YueChuCheng <maggie9907@gmail.com>
@YueChuCheng YueChuCheng requested review from yukke42 and a team as code owners November 18, 2022 07:21
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) and removed component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Nov 18, 2022
pre-commit-ci bot and others added 3 commits November 18, 2022 07:23
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YueChuCheng
Just some minor comments.

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 10.43% // Head: 10.46% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (3a55aba) compared to base (96652f9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2304      +/-   ##
==========================================
+ Coverage   10.43%   10.46%   +0.03%     
==========================================
  Files        1264     1249      -15     
  Lines       92257    90919    -1338     
  Branches    21129    20728     -401     
==========================================
- Hits         9624     9517     -107     
+ Misses      72423    71309    -1114     
+ Partials    10210    10093     -117     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.47% <ø> (+0.06%) ⬆️ Carriedforward from 2adedd9

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...intcloud_map_loader/pointcloud_map_loader_node.cpp 0.00% <0.00%> (-2.57%) ⬇️
...n/motion_utils/test/src/resample/test_resample.cpp 25.87% <0.00%> (-0.04%) ⬇️
perception/tensorrt_yolo/src/nodelet.cpp 0.00% <0.00%> (ø)
planning/obstacle_stop_planner/src/node.cpp 0.00% <0.00%> (ø)
planning/route_handler/src/route_handler.cpp 0.00% <0.00%> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <0.00%> (ø)
planning/obstacle_avoidance_planner/src/node.cpp 0.00% <0.00%> (ø)
sensing/imu_corrector/src/imu_corrector_core.cpp 0.00% <0.00%> (ø)
planning/static_centerline_optimizer/src/utils.cpp 0.00% <0.00%> (ø)
...ocalization/ekf_localizer/src/state_transition.cpp 100.00% <0.00%> (ø)
... and 110 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: YueChuCheng <maggie9907@gmail.com>
Signed-off-by: YueChuCheng <maggie9907@gmail.com>
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@yukke42 Could you approve this as a codeowner?

@yukke42
Copy link
Contributor

yukke42 commented Nov 30, 2022

Cloud you rename README to README.md so that we can see markdown preview?

Signed-off-by: YueChuCheng <maggie9907@gmail.com>
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Nov 30, 2022
@YueChuCheng
Copy link
Contributor Author

Cloud you rename README to README.md so that we can see markdown preview?

Sure, just rename the file.

@miursh miursh merged commit c2f47b2 into autowarefoundation:main Dec 1, 2022
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…unch file (autowarefoundation#2304)

* Add centerpoint_vs_centerpoint-tiny launch file

This launch file is for showing centerpoint and centerpoint_tinymodels’ results simultaneously, making it easier to visualize and compare the performance.

Signed-off-by: YueChuCheng <maggie9907@gmail.com>

* ci(pre-commit): autofix

* Relocate folder from tier4_perception_launch to lidar_centerpoint.

Signed-off-by: YueChuCheng <maggie9907@gmail.com>

* ci(pre-commit): autofix

* Correct XML format

Signed-off-by: YueChuCheng <maggie9907@gmail.com>

* ci(pre-commit): autofix

* Remove redundant code. Add sample rosbag link provided by autoware.

Signed-off-by: YueChuCheng <maggie9907@gmail.com>

* Correct spelling mistake.

Signed-off-by: YueChuCheng <maggie9907@gmail.com>

* Rename README file

Signed-off-by: YueChuCheng <maggie9907@gmail.com>

Signed-off-by: YueChuCheng <maggie9907@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…unch file (autowarefoundation#2304)

* Add centerpoint_vs_centerpoint-tiny launch file

This launch file is for showing centerpoint and centerpoint_tinymodels’ results simultaneously, making it easier to visualize and compare the performance.

Signed-off-by: YueChuCheng <maggie9907@gmail.com>

* ci(pre-commit): autofix

* Relocate folder from tier4_perception_launch to lidar_centerpoint.

Signed-off-by: YueChuCheng <maggie9907@gmail.com>

* ci(pre-commit): autofix

* Correct XML format

Signed-off-by: YueChuCheng <maggie9907@gmail.com>

* ci(pre-commit): autofix

* Remove redundant code. Add sample rosbag link provided by autoware.

Signed-off-by: YueChuCheng <maggie9907@gmail.com>

* Correct spelling mistake.

Signed-off-by: YueChuCheng <maggie9907@gmail.com>

* Rename README file

Signed-off-by: YueChuCheng <maggie9907@gmail.com>

Signed-off-by: YueChuCheng <maggie9907@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants