From 626b1df74902f10f44be0168559d7eb10643bceb Mon Sep 17 00:00:00 2001 From: Yuki Takagi Date: Mon, 26 Aug 2024 16:16:51 +0900 Subject: [PATCH] po Signed-off-by: Yuki Takagi --- .../pid_longitudinal_controller.hpp | 6 +- .../src/pid_longitudinal_controller.cpp | 12 +- .../plot_juggler_trajectory_follower.xml | 249 ++++++++------- ...plot_juggler_trajectory_follower_accfb.xml | 298 ------------------ 4 files changed, 140 insertions(+), 425 deletions(-) delete mode 100644 control/autoware_trajectory_follower_node/config/plot_juggler_trajectory_follower_accfb.xml diff --git a/control/autoware_pid_longitudinal_controller/include/autoware/pid_longitudinal_controller/pid_longitudinal_controller.hpp b/control/autoware_pid_longitudinal_controller/include/autoware/pid_longitudinal_controller/pid_longitudinal_controller.hpp index 95fa9904f4d2a..1d4192d51d98d 100644 --- a/control/autoware_pid_longitudinal_controller/include/autoware/pid_longitudinal_controller/pid_longitudinal_controller.hpp +++ b/control/autoware_pid_longitudinal_controller/include/autoware/pid_longitudinal_controller/pid_longitudinal_controller.hpp @@ -169,7 +169,7 @@ class PidLongitudinalController : public trajectory_follower::LongitudinalContro // drive PIDController m_pid_vel; - std::unique_ptr m_lpf_vel_error{nullptr}; + std::shared_ptr m_lpf_vel_error{nullptr}; bool m_enable_integration_at_low_speed; double m_current_vel_threshold_pid_integrate; double m_time_threshold_before_pid_integrate; @@ -198,7 +198,7 @@ class PidLongitudinalController : public trajectory_follower::LongitudinalContro // acc feedback double m_acc_feedback_gain; - std::unique_ptr m_lpf_acc_error{nullptr}; + std::shared_ptr m_lpf_acc_error{nullptr}; // acceleration limit double m_max_acc; @@ -213,7 +213,7 @@ class PidLongitudinalController : public trajectory_follower::LongitudinalContro enum class SlopeSource { RAW_PITCH = 0, TRAJECTORY_PITCH, TRAJECTORY_ADAPTIVE }; SlopeSource m_slope_source{SlopeSource::RAW_PITCH}; double m_adaptive_trajectory_velocity_th; - std::unique_ptr m_lpf_pitch{nullptr}; + std::shared_ptr m_lpf_pitch{nullptr}; double m_max_pitch_rad; double m_min_pitch_rad; diff --git a/control/autoware_pid_longitudinal_controller/src/pid_longitudinal_controller.cpp b/control/autoware_pid_longitudinal_controller/src/pid_longitudinal_controller.cpp index 4f8ed3b7560c6..96e2796a91d22 100644 --- a/control/autoware_pid_longitudinal_controller/src/pid_longitudinal_controller.cpp +++ b/control/autoware_pid_longitudinal_controller/src/pid_longitudinal_controller.cpp @@ -104,7 +104,7 @@ PidLongitudinalController::PidLongitudinalController( // set lowpass filter for vel error and pitch const double lpf_vel_error_gain{node.declare_parameter("lpf_vel_error_gain")}; - m_lpf_vel_error = std::make_unique(0.0, lpf_vel_error_gain); + m_lpf_vel_error = std::make_shared(0.0, lpf_vel_error_gain); m_enable_integration_at_low_speed = node.declare_parameter("enable_integration_at_low_speed"); @@ -167,7 +167,7 @@ PidLongitudinalController::PidLongitudinalController( // parameters for acc feedback { const double lpf_acc_error_gain{node.declare_parameter("lpf_acc_error_gain")}; - m_lpf_acc_error = std::make_unique(0.0, lpf_acc_error_gain); + m_lpf_acc_error = std::make_shared(0.0, lpf_acc_error_gain); m_acc_feedback_gain = node.declare_parameter("acc_feedback_gain"); } @@ -184,7 +184,7 @@ PidLongitudinalController::PidLongitudinalController( m_adaptive_trajectory_velocity_th = node.declare_parameter("adaptive_trajectory_velocity_th"); // [m/s^2] const double lpf_pitch_gain{node.declare_parameter("lpf_pitch_gain")}; - m_lpf_pitch = std::make_unique(0.0, lpf_pitch_gain); + m_lpf_pitch = std::make_shared(0.0, lpf_pitch_gain); m_max_pitch_rad = node.declare_parameter("max_pitch_rad"); // [rad] m_min_pitch_rad = node.declare_parameter("min_pitch_rad"); // [rad] @@ -872,9 +872,9 @@ PidLongitudinalController::Motion PidLongitudinalController::calcCtrlCmd( m_debug_values.setValues(DebugValues::TYPE::ACC_CMD_ACC_FB_APPLIED, acc_cmd); RCLCPP_DEBUG( logger_, - "[acc feedback]: raw_ctrl_cmd.acc: %1.3f, control_data.current_motion.acc: %1.3f, " - "m_lpf_acc_error.getValue(): %1.3f, acc_cmd: %1.3f", - raw_ctrl_cmd.acc, control_data.current_motion.acc, 0.0, acc_cmd); + "[acc feedback]: raw_ctrl_cmd.acc: %1.3f, control_data.current_motion.acc: %1.3f, acc_cmd: " + "%1.3f", + raw_ctrl_cmd.acc, control_data.current_motion.acc, acc_cmd); ctrl_cmd_as_pedal_pos.acc = applySlopeCompensation(acc_cmd, control_data.slope_angle, control_data.shift); diff --git a/control/autoware_trajectory_follower_node/config/plot_juggler_trajectory_follower.xml b/control/autoware_trajectory_follower_node/config/plot_juggler_trajectory_follower.xml index ab127c2d47b97..e458edaf6c471 100644 --- a/control/autoware_trajectory_follower_node/config/plot_juggler_trajectory_follower.xml +++ b/control/autoware_trajectory_follower_node/config/plot_juggler_trajectory_follower.xml @@ -1,130 +1,130 @@ - - + + - - + + - - + + - + - + - + - + - + - + - + - - + + - + - + - - + + - + - + - + - - + + - + - + - + - + - - + + - + - + - - + + @@ -133,100 +133,114 @@ - + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - - + + - + - + - + - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -234,17 +248,17 @@ - + - + - + @@ -254,13 +268,13 @@ - + - + @@ -272,11 +286,10 @@ - + - diff --git a/control/autoware_trajectory_follower_node/config/plot_juggler_trajectory_follower_accfb.xml b/control/autoware_trajectory_follower_node/config/plot_juggler_trajectory_follower_accfb.xml deleted file mode 100644 index d5ab47a3c16fa..0000000000000 --- a/control/autoware_trajectory_follower_node/config/plot_juggler_trajectory_follower_accfb.xml +++ /dev/null @@ -1,298 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -