From 6eebf83a82eb82d33e3bc3b9b515a09e4643ae55 Mon Sep 17 00:00:00 2001 From: Kasper Mecklenburg <30662532+kaspermeck-arm@users.noreply.github.com> Date: Mon, 14 Aug 2023 12:46:07 -0700 Subject: [PATCH 1/3] Update parameters.md Signed-off-by: kaspermeck-arm --- .../coding-guidelines/ros-nodes/parameters.md | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/docs/contributing/coding-guidelines/ros-nodes/parameters.md b/docs/contributing/coding-guidelines/ros-nodes/parameters.md index 18ba8ab24d7..7eac7a36ec2 100644 --- a/docs/contributing/coding-guidelines/ros-nodes/parameters.md +++ b/docs/contributing/coding-guidelines/ros-nodes/parameters.md @@ -126,7 +126,11 @@ Autoware has the following two types of parameter files for ROS packages: "INSERT_BOUND_CONDITION(S)": "INSERT_BOUND_VALUE(S)" } }, - "required": ["INSERT_PARAMETER_1_NAME", "INSERT_PARAMETER_N_NAME"] + "required": [ + "INSERT_PARAMETER_1_NAME", + "INSERT_PARAMETER_N_NAME" + ], + "additionalProperties": false } }, "properties": { @@ -137,10 +141,12 @@ Autoware has the following two types of parameter files for ROS packages: "$ref": "#/definitions/INSERT_ROS_NODE_NAME" } }, - "required": ["ros__parameters"] + "required": ["ros__parameters"], + "additionalProperties": false } }, - "required": ["/**"] + "required": ["/**"], + "additionalProperties": false } ``` From 5a36e065f9ad199b25df720a92922d100fb745a8 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 14 Aug 2023 19:46:52 +0000 Subject: [PATCH 2/3] style(pre-commit): autofix Signed-off-by: kaspermeck-arm --- docs/contributing/coding-guidelines/ros-nodes/parameters.md | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/docs/contributing/coding-guidelines/ros-nodes/parameters.md b/docs/contributing/coding-guidelines/ros-nodes/parameters.md index 7eac7a36ec2..fb565a87a1c 100644 --- a/docs/contributing/coding-guidelines/ros-nodes/parameters.md +++ b/docs/contributing/coding-guidelines/ros-nodes/parameters.md @@ -126,10 +126,7 @@ Autoware has the following two types of parameter files for ROS packages: "INSERT_BOUND_CONDITION(S)": "INSERT_BOUND_VALUE(S)" } }, - "required": [ - "INSERT_PARAMETER_1_NAME", - "INSERT_PARAMETER_N_NAME" - ], + "required": ["INSERT_PARAMETER_1_NAME", "INSERT_PARAMETER_N_NAME"], "additionalProperties": false } }, From 6277cd080fbb3927cc7b6c4495493828eb04f611 Mon Sep 17 00:00:00 2001 From: Kasper Mecklenburg <30662532+kaspermeck-arm@users.noreply.github.com> Date: Mon, 14 Aug 2023 13:20:09 -0700 Subject: [PATCH 3/3] Update parameters.md Signed-off-by: kaspermeck-arm --- docs/contributing/coding-guidelines/ros-nodes/parameters.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/contributing/coding-guidelines/ros-nodes/parameters.md b/docs/contributing/coding-guidelines/ros-nodes/parameters.md index fb565a87a1c..45c437406dd 100644 --- a/docs/contributing/coding-guidelines/ros-nodes/parameters.md +++ b/docs/contributing/coding-guidelines/ros-nodes/parameters.md @@ -117,13 +117,13 @@ Autoware has the following two types of parameter files for ROS packages: "type": "INSERT_TYPE", "description": "INSERT_DESCRIPTION", "default": "INSERT_DEFAULT", - "INSERT_BOUND_CONDITION(S)": "INSERT_BOUND_VALUE(S)" + "INSERT_BOUND_CONDITION(S)": INSERT_BOUND_VALUE(S) }, "INSERT_PARAMETER_N_NAME": { "type": "INSERT_TYPE", "description": "INSERT_DESCRIPTION", "default": "INSERT_DEFAULT", - "INSERT_BOUND_CONDITION(S)": "INSERT_BOUND_VALUE(S)" + "INSERT_BOUND_CONDITION(S)": INSERT_BOUND_VALUE(S) } }, "required": ["INSERT_PARAMETER_1_NAME", "INSERT_PARAMETER_N_NAME"],