Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polynomial coefficients recovery #1307

Closed
Tracked by #1126 ...
dariolina opened this issue Mar 27, 2023 · 1 comment · Fixed by #1450
Closed
Tracked by #1126 ...

polynomial coefficients recovery #1307

dariolina opened this issue Mar 27, 2023 · 1 comment · Fixed by #1450
Labels
consensus Something that impacts consensus improvement it is already working, but can be better upstream Blocked by upstream
Milestone

Comments

@dariolina
Copy link
Member

dariolina commented Mar 27, 2023

Similar to normal erasure coding recovery, but recovers the polynomial in coefficient form for use with KZG, instead of source chunks. Corresponds to recover_poly_from_samples from rust_kzg but without the last FFT in this line (as proposed in this upstream issue). See spec.

fn recover_poly(
            samples: &[Option<BlsScalar>],
            fs: &FFTSettings,
        ) -> Result<Polynomial, Error> {
       }
@dariolina dariolina added improvement it is already working, but can be better consensus Something that impacts consensus upstream Blocked by upstream labels Mar 27, 2023
@nazar-pc
Copy link
Member

From experimental testing, the cost of this is quite low for us, so not a priority for now

@nazar-pc nazar-pc added this to the Beyond Gemini milestone Apr 13, 2023
@nazar-pc nazar-pc mentioned this issue May 12, 2023
1 task
@nazar-pc nazar-pc moved this from In Progress to Under Review in Subspace core (node, farmer, etc.) May 12, 2023
@nazar-pc nazar-pc modified the milestones: Beyond Gemini 3, Gemini 3 May 12, 2023
@github-project-automation github-project-automation bot moved this from Under Review to Closed in Subspace core (node, farmer, etc.) May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus Something that impacts consensus improvement it is already working, but can be better upstream Blocked by upstream
Projects
Development

Successfully merging a pull request may close this issue.

2 participants