Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #240 added dependency on addressable but it isn't in the gemspec. #246

Closed
rally25rs opened this issue Oct 21, 2020 · 3 comments
Closed

Comments

@rally25rs
Copy link

Description

Version 4.17.0 of this gem now has a dependency on addressable due to #240 but no one added the dependency to the gemspec, so using it results in

LoadError: cannot load such file -- addressable/uri
/usr/local/bundle/gems/bootsnap-1.4.8/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:34:in `require'
...
/usr/local/bundle/gems/auth0-4.17.0/lib/auth0/mixins/httpproxy.rb:1:in `<main>'
...
/usr/local/bundle/gems/auth0-4.17.0/lib/auth0/mixins.rb:8:in `<main>'
...
/usr/local/bundle/gems/auth0-4.17.0/lib/auth0.rb:2:in `<main>'
...

Seems like Gemfile and auth0.gemspec should include addressable as dependencies.

Reproduction

Use v4.17.0 of this gem in a Rails project that doesn't already have a dependency on addressable.

Environment

Please provide the following:

  • Version of this library used: 4.17.0
  • Version of the platform or framework used, if applicable:
  • Other relevant versions (language, server software, OS, browser):
  • Other modules/plugins/libraries that might be involved:
@davidpatrick
Copy link
Contributor

Thanks for raising this @rally25rs, looks like it didn't make it into the Gemfile. I will get this patched up right away

@davidpatrick
Copy link
Contributor

Fixed in #247

4.17.1 on its way

@rally25rs
Copy link
Author

Confirmed fixed in 4.17.1 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants