Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TLSv1.2 on older Android API #126

Closed
carlyonj opened this issue Oct 30, 2017 · 4 comments
Closed

Support TLSv1.2 on older Android API #126

carlyonj opened this issue Oct 30, 2017 · 4 comments

Comments

@carlyonj
Copy link

carlyonj commented Oct 30, 2017

Auth0 supports down to API 15 but as detailed here TLSv1.1 and v1.2 are not used by default on older APIs. Potential solutions are detailed here, here and here.

Currently by using the Auth0 API you are unable to support devices using APIs lower than 21 with a backend that enforced TLSv1.2. Because of this the Auth0 android library is not very useful to any apps that plan on supporting older devices in a secure manner.

@dj-mal
Copy link
Contributor

dj-mal commented Nov 2, 2017

Facing the same problem here. The token endpoint is using TLS v1.2 so the authentication flow doesn't work with Androids with API 16-20.

Is it possible to create a new constructor in UsersAPIClient and AuthenticationAPIClient with OkHttpClient so that TLSv1.2 could be enabled via a custom OkHttpClient?

If that's not preferable, a new method that would modify the OkHttpClient to support TLSv1.2 could also be added to those API client classes to extend support to those older Android devices.

@lbalmaceda
Copy link
Contributor

lbalmaceda commented Nov 2, 2017

I would prefer a method that sets a flag rather than exposing the OkHttp client. Maybe in the Auth0 class, or in both API client classes. We have other priorities at the moment, and I don't think we'll be able to get into this in the next 2 months. Feel free to fork the repo and add the required changes or propose a PR and we'll review it.

@dj-mal
Copy link
Contributor

dj-mal commented Nov 6, 2017

PR Submitted as #128

@lbalmaceda
Copy link
Contributor

This has been released on version 1.12.0. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants