From 0d5aabf210ff81223e0196a354c88bf31b9eab70 Mon Sep 17 00:00:00 2001
From: Renato Alves <alves.rjc@gmail.com>
Date: Wed, 23 Jun 2021 21:46:54 +0200
Subject: [PATCH] Test replies via direct messages

---
 .../test_direct_message_plugin.py             | 73 +++++++++++++++++++
 tests/integration_tests/utils.py              | 13 +++-
 2 files changed, 85 insertions(+), 1 deletion(-)
 create mode 100644 tests/integration_tests/test_direct_message_plugin.py

diff --git a/tests/integration_tests/test_direct_message_plugin.py b/tests/integration_tests/test_direct_message_plugin.py
new file mode 100644
index 00000000..4c9ddf83
--- /dev/null
+++ b/tests/integration_tests/test_direct_message_plugin.py
@@ -0,0 +1,73 @@
+import random
+import time
+from string import ascii_letters
+
+from .utils import start_bot  # noqa, only imported so that the bot is started
+from .utils import MAIN_BOT_ID, OFF_TOPIC_ID, RESPONSE_TIMEOUT, TEAM_ID
+from .utils import driver as driver_fixture
+from .utils import expect_reply
+
+# Hacky workaround to import the fixture without linting errors
+driver = driver_fixture
+
+
+# Verifies that the bot is running and listening to this non-targeted message
+def test_start(driver):
+    post = driver.create_post(OFF_TOPIC_ID, "starting direct tests!")
+    assert expect_reply(driver, post)["message"] == "Bring direct on!"
+
+
+# Verifies that the bot is running and listening to this non-targeted message
+class TestDirectPlugin:
+    def test_start_direct(self, driver):
+        def bot_and_user_direct_channel(channel):
+            """Find which channels are direct and have the user and bot as
+            participants."""
+            name = channel["name"]
+
+            user_chan = driver.user_id in name
+            bot_chan = MAIN_BOT_ID in name
+            # D = direct message channel
+            direct = channel["type"] == "D"
+
+            return user_chan and bot_chan and direct
+
+        # Create a random string of text so we can uniquely identify the bot reply
+        random_string = "".join(random.choices(ascii_letters, k=30))
+        trigger = f"direct reply {random_string}"
+        reply = f"Telling you privately! {random_string}"
+
+        # The bot should reply with a direct message
+        # which is implemented by mattermost as a channel
+        driver.create_post(OFF_TOPIC_ID, trigger)
+
+        user_channels = driver.channels.get_channels_for_user(driver.user_id, TEAM_ID)
+        channels = list(filter(bot_and_user_direct_channel, user_channels))
+
+        # We need to wait for the reply to be processed by mattermost
+        # and the private channel created
+        retries = 2
+
+        for _ in range(retries):
+            if len(channels) != 1:
+                time.sleep(RESPONSE_TIMEOUT)
+                user_channels = driver.channels.get_channels_for_user(
+                    driver.user_id, TEAM_ID
+                )
+                channels = list(filter(bot_and_user_direct_channel, user_channels))
+            else:
+                channel = channels.pop()
+                break
+        else:
+            raise ValueError("Couldn't find a direct channel between user and bot")
+
+        for _ in range(retries):
+            posts = driver.posts.get_posts_for_channel(channel["id"])
+
+            for post in posts["posts"].values():
+                if post["message"] == reply:
+                    return
+
+            time.sleep(RESPONSE_TIMEOUT)
+        else:
+            raise ValueError(f"Direct reply '{reply}' not found among direct messages")
diff --git a/tests/integration_tests/utils.py b/tests/integration_tests/utils.py
index 46a79562..d26dd259 100644
--- a/tests/integration_tests/utils.py
+++ b/tests/integration_tests/utils.py
@@ -46,6 +46,17 @@ async def reply_start(self, message: Message):
         self.driver.reply_to(message, "Bring it on!")
 
 
+# For direct message tests
+class DirectPlugin(Plugin):
+    @listen_to("^starting direct tests")
+    async def reply_start_direct(self, message: Message):
+        self.driver.reply_to(message, "Bring direct on!")
+
+    @listen_to("^direct reply (.*)")
+    async def reply_direct(self, message: Message, text):
+        self.driver.reply_to(message, f"Telling you privately! {text}", direct=True)
+
+
 @pytest.fixture(scope="session")
 def driver():
     return Bot(
@@ -81,7 +92,7 @@ def start_bot(request):
                 WEBHOOK_HOST_URL="http://127.0.0.1",
                 WEBHOOK_HOST_PORT=8579,
             ),
-            plugins=[TestPlugin(), ExamplePlugin(), WebHookExample()],
+            plugins=[DirectPlugin(), TestPlugin(), ExamplePlugin(), WebHookExample()],
         )
 
         def run_bot():