-
Notifications
You must be signed in to change notification settings - Fork 322
Add newly opened buffers when not following host #274
Comments
We're currently working on RFC-001 (tracked in #268) which will offer the ability for guests to use the fuzzy-finder to open any buffer that's present in the host's workspace. Our current thinking is that if you're not following the host, you probably don't want new tabs appearing in your editor every time the host opens a new buffer. Instead, you can re-follow the host to view/open their current buffer, and once RFC-001 is fully implemented, you'll also be able to use the fuzzy-finder to open any other buffers that the host has shared. Once RFC-001 is implemented, if there are use cases you have in mind that aren't solved by following the host or by using the fuzzy finder, we'd love to hear about those use cases. |
I'm not sure if RFC-001 completely handled this issue. Following the above reproduction steps, I was unable to use the fuzzy-finder to get the remote file. In the picture, the host (right) has a file open, |
@CaptainJohnyAppleSeed: RFC-001's fuzzy-finder integration is dependent on fuzzy-finder v1.8.0 which will be included in Atom 1.26. Keep an eye out for a beta release of Atom 1.26 soon. 😄 |
With the updates in teletype v0.10.0 and fuzzy-finder v1.8.0, we think we've addressed the needs described in this issue, so I'm going to close this out. Thanks for opening this issue, @IbisLiven. 🙇 |
Description
When a guest is following the host, any new buffers the host opens are added to the guest's workspace as a remote buffer. However if the guest isn't following the host (the guest is looking at different remote buffer, the host is following the guest instead, ...), any new buffers added by the host aren't added to the guest's workspace.
Could a change be made to add all the buffers the host opens while sharing a portal to every guest's workspace? or is this there a reason that this isn't the current behaviour? (i don't know if this is a feature or a bug, or just something overlooked)
Steps to Reproduce
Expected behavior:
When guest is following host: new buffers added by host are added to the guest's workspace
(guest is switched to whatever host is looking at)
When guest it not following host: new buffers added by host are added to the guest's workspace
(guest is not switched to whatever host is looking at)
Actual behavior:
When guest is following host: new buffers added by host are added to the guest's workspace
(guest is switched to whatever host is looking at)
When guest it not following host: new buffers added by host are not added to the guest's workspace
(guest is not switched to whatever host is looking at)
Reproduces how often:
100%
Versions
Atom: 1.23.0
Electron: 1.6.15
Chrome: 56.0.2924.87
Node: 7.4.0
Teletype 0.3.0
Additional Information
The text was updated successfully, but these errors were encountered: