Decoration is throwing exceptions

[nathansobo]

Not quite sure why minimap is reusing the Decoration class from atom/atom. It would be better if it defined its own class since that's not a public API. That said, it looks like you're missing an implementation for decorationDidChange, which Decoration attempts to call during setProperties. As a result, we're seeing a lot of traces like the following showing up in our exception tracker.

TypeError Uncaught TypeError: undefined is not a function
    src/decoration.js:135:28 Decoration.module.exports.Decoration.setProperties
    src/decoration.js:58:12 new Decoration
    /Users/buddy/.atom/packages/minimap/lib/mixins/decoration-management.coffee:203:22 Minimap.module.exports.DecorationManagement.decorateMarker
    /Users/buddy/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected-view.coffee:25:30 FakeEditor.(anonymous function) [as decorateMarker]
    node_modules/text-buffer/lib/text-buffer.js:842:9 TextBuffer.module.exports.TextBuffer.scanInRange
    src/text-editor.js:2095:26 TextEditor.module.exports.TextEditor.scanInBufferRange
    /Users/buddy/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected-view.coffee:18:30 FakeEditor.(anonymous function) [as scanInBufferRange]
    /Users/buddy/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected-view.coffee:68:14 MinimapHighlightSelectedView.handleSelection
    /Users/buddy/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:1:1 MinimapHighlightSelectedView.handleSelection
    node_modules/event-kit/lib/emitter.js:82:11 Emitter.module.exports.Emitter.emit
    src/text-editor.js:2082:27 TextEditor.module.exports.TextEditor.selectionRangeChanged
    src/selection.js:877:26 Selection.module.exports.Selection.screenRangeChanged
    node_modules/event-kit/lib/emitter.js:82:11 Emitter.module.exports.Emitter.emit
    src/marker.js:270:27 Marker.module.exports.Marker.notifyObservers
    node_modules/event-kit/lib/emitter.js:82:11 Emitter.module.exports.Emitter.emit
    node_modules/text-buffer/lib/marker.js:400:20 Marker.module.exports.Marker.emitChangeEvent
    node_modules/text-buffer/lib/marker.js:345:12 Marker.module.exports.Marker.update
    node_modules/text-buffer/lib/marker.js:108:19 Marker.module.exports.Marker.setRange
    src/marker.js:137:32 Marker.module.exports.Marker.setBufferRange
    src/selection.js:906:7 Selection.module.exports.Selection.modifySelection
    src/selection.js:110:19 Selection.module.exports.Selection.setBufferRange
    src/selection.js:386:12 Selection.module.exports.Selection.selectWord
    src/text-editor-component.js:561:42 TextEditorComponent.module.exports.TextEditorComponent.onMouseDown
    src/text-editor-component.js:3:61 <anonymous>

[abe33]

Yes, that's my mistake, I should have cloned the Decoration class from the start, I'll try to find some time today to fix this.

[nathansobo]

Thanks @abe33!