Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need ability to create Smart Remote Repository by supporting 'contentSynchronisation' argument #76

Closed
AshutoshNirkhe opened this issue Jun 2, 2020 · 3 comments

Comments

@AshutoshNirkhe
Copy link
Contributor

AshutoshNirkhe commented Jun 2, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently terraform-provider-artifactory v2.0.0-alpha1 doesn't support an argument called 'contentSynchronisation' that is necessary for creating a 'Smart Remote Repository' in JFrog Artifactory (It's a must for Artifactory Edge license).
Ref : REST API section at the bottom of link - https://www.jfrog.com/confluence/display/JFROG/Smart+Remote+Repositories

Because of this we are getting below error in terraform apply -
Status:400 Message:Only smart remote repositories are supported with Artifactory Edge license

It will be great if you could add this support as this is available via JFrog REST API!

New or Affected Resource(s)

  • artifactory_remote_repository

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.
resource "artifactory_remote_repository" "smart-remote-repo" {
  key             = "my-smart-remote-repo"
  package_type    = "generic"
  url             = "https://my-jfrog.org/artifactory/generic-local-repo"
  repo_layout_ref = "simple-default"   
  content_synchronisation = {
    enabled = true,
    statistics = {
      enabled = true
    },
    properties = {
      enabled = false
    },
    source = {
      originAbsenceDetection = false
    }
  }
}

References

https://www.jfrog.com/confluence/display/JFROG/Smart+Remote+Repositories

  • #0000
@AshutoshNirkhe
Copy link
Contributor Author

I have raised the PR for this issue here, please review -
https://github.com/atlassian/terraform-provider-artifactory/pull/77/files

@djsly
Copy link

djsly commented Jun 10, 2020

This can be closed I think

@AshutoshNirkhe
Copy link
Contributor Author

Closing, as the PR is merged and we are able to create remote repos after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants