Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider enabling Next.js caching for Netlify builds #843

Closed
smoya opened this issue Jun 28, 2022 · 22 comments · Fixed by #1669
Closed

Consider enabling Next.js caching for Netlify builds #843

smoya opened this issue Jun 28, 2022 · 22 comments · Fixed by #1669
Assignees
Labels
bounty AsyncAPI Bounty program related label enhancement level/medium AsyncAPI Bounty program related label

Comments

@smoya
Copy link
Member

smoya commented Jun 28, 2022

Reason/Context

Netlify builds show the following warning:

6:49:31 PM: warn  - No build cache found. Please configure build caching for faster rebuilds. Read more: https://nextjs.org/docs/messages/no-cache

It seems we can install a Netlify plugin so we can set a cache folder. See https://github.com/netlify/netlify-plugin-nextjs

cc @fmvilas @derberg @magicmatatjahu

@magicmatatjahu
Copy link
Member

@smoya Do you wanna handle it and test it?

@fmvilas
Copy link
Member

fmvilas commented Jul 5, 2022

@smoya I think we had it and got removed but I don't recall the reasons.

@derberg
Copy link
Member

derberg commented Jul 5, 2022

actually I thought we have it as sometimes build failed and I run clear cache and build and then it works 😆

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Nov 3, 2022
@smoya
Copy link
Member Author

smoya commented Nov 8, 2022

still relevant

Copy link
Member

derberg commented Nov 8, 2022

but do we really need it? Nobody ever complained about the speed of the build

@github-actions github-actions bot removed the stale label Nov 9, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@akshatnema
Copy link
Member

akshatnema commented Apr 12, 2023

@derberg Yes we do need this now. We have to use Next js caching on Netlify builds. With the increase in the amount of data and functionalities inside the website, we are constantly decreasing the performance of the website. Hence, it is needed to enable inbuilt Next js caching on the website. Reference - https://nextjs.org/docs/going-to-production

@derberg derberg added bounty AsyncAPI Bounty program related label level/medium AsyncAPI Bounty program related label labels Apr 19, 2023
@thulieblack
Copy link
Member

This issue is part of the AsyncAPI Bounty Program, interested contributors need to follow the guidelines below to ensure fairness and timely completion of assigned tasks:

Task Assignment

The assignment of tasks will be prioritized in the following order:

  • AsyncAPI maintainers (from any repository)
  • Regular contributors (individuals who have merged three or more pull requests)
  • Other (if an individual doesn't fall under the above, the maintainer can determine the criteria i.e regular volunteers, etc)

We encouraged everyone to apply as long as the task is for you (falls under your skill set). We will not be using the first comment - get assigned method for assignments. Instead, we will provide 3 days to consider all individuals interested before assigning any bounty task.

Deadline

To maintain accountability and ensure the timely completion of the deadline for this task will be 4- 6 weeks from the date of assignment. If a contributor requires an extension on their task, it should be communicated and approved by the maintainer.

Issue Tracking and Updates

Contributors must provide weekly updates on the task they are working on to help maintainers stay informed of progress. If a contributor fails to provide an update, they will be reminded via a ping. If a contributor fails to provide an update after three pings over three weeks, we will assume they have silently dropped the issue, and it will be reassigned to someone else.

Issue Drop-outs

Any contributor who drops an assigned issue will be penalized and will not be eligible to participate in the bounty program for 6 months. We understand that unforeseen circumstances can arise, and dropping an assigned issue may be unavoidable in some cases. However, we believe that enforcing this penalty is necessary to ensure the effectiveness of the bounty program, respect maintainer time, and honor the efforts of other contributors who could have solved the issue but were unable to do so due to the drop-out.

We encourage all contributors to follow these guidelines to ensure a fair and timely completion of tasks assigned through our bounty program.

@sambhavgupta0705
Copy link
Member

Hey, I would like to work on this one.

Copy link
Member

derberg commented Apr 25, 2023

Awesome, you are already regular contributor, super to get your help 💪

@akshatnema
Copy link
Member

@sambhavgupta0705 What's the status of this issue?

@sambhavgupta0705
Copy link
Member

For now I'm reading about cache and netlify build
Will work on this soon as I was busy with my exams.

@thulieblack
Copy link
Member

Issue Tracking and Updates
Contributors must provide weekly updates on the task they are working on to help maintainers stay informed of progress. If a contributor fails to provide an update, they will be reminded via a ping. If a contributor fails to provide an update after three pings over three weeks, we will assume they have silently dropped the issue, and it will be reassigned to someone else.

@sambhavgupta0705 please don't forget to give weekly updates, it I'll be easy for us to track the issue

@sambhavgupta0705
Copy link
Member

Yes @thulieblack will keep this in mind ,currently I am reading about cache and netlify build and how to work with them.

@sambhavgupta0705
Copy link
Member

I read about caching and now I am configuring the netlify caching mentioned in this blog for Ci

@sambhavgupta0705
Copy link
Member

I am having some errors in deploying my local fork .Can someone help with that?

@thulieblack
Copy link
Member

@sambhavgupta0705 did you manage solving the errors you where facing?

@sambhavgupta0705
Copy link
Member

Yes @thulieblack all the errors are resolved
@derberg is reviewing the PR

@akshatnema akshatnema linked a pull request May 23, 2023 that will close this issue
@derberg
Copy link
Member

derberg commented May 29, 2023

@sambhavgupta0705 congrats on completing your first bounty issue

@thulieblack on to you, not sure if you have some copy/paste message for people on how to claim bounty payment, so yeah, leaving that communication up to you

@sambhavgupta0705
Copy link
Member

Thanks @derberg @akshatnema and @thulieblack for providing this opportunity 🙌

@thulieblack
Copy link
Member

Hey @sambhavgupta0705, congratulations on completing your bounty issue.
This is how'll claim your payment:

  1. Go to AsyncAPI Open Collective page
  2. Submit an a expense and add details for the bounty issue
    image
  3. Voila! you get your coins🤑 !!

@aeworxet aeworxet moved this to Completed in Bounty Program Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty AsyncAPI Bounty program related label enhancement level/medium AsyncAPI Bounty program related label
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

8 participants