-
-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[📑 Docs]: found one duplicate paragraph in docs #779
Comments
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. |
Hey! I think you forgot to give title to your PR! |
@pratik2315 thanks! just added it! |
hey are you working on this issue? or I would like to work on it please |
@starlightknown go ahead and start a PR 👍🏻 😄 |
are we allowed to raise a PR for changes ourselves? |
@yy185058 Yes! That is how OSS works ❤️ Anyone can open an issue for a contribution proposal and then do the work with a PR. You just cannot get your change merged until core maintainers in this OSS project approve your PR. If you want to fix this, then just let me know so that we don't confuse poor @starlightknown 😆 |
thank you for your reply! yes I can try to fix this |
OK sounds great! If you get stuck let us know @yy185058 ... sorry for the confusion @starlightknown! It looks like Yimin is going to do a PR. |
Hey I was trying to raise a PR but saw this issue:
|
Hey there! Did u add upstream URL of the main repo in your forked project? Can you run a |
sorry this is my first time contributing to OSS, here's what I see for that command:
what I did is cloned the source code to my local and created a branch from it, and now trying to push changes from that branch |
Got the error! You should also add |
You have set up the main repo on your local machine you should set up the forked repo on your pc and then perform the |
thank you! is this the correct flow:
i have a feeling that this is wrong as in this case seems like the cloning repo isn't used at all... |
|
After reading this issue, I think there is a need to work on #748. What do you think @alequetzalli? |
thank you so much for the patience, I just had my PR raised! |
Hello there @yy185058. You sure? I cannot see your PR listed anywhere😅! |
They haven't linked this issue in their PR @pratik2315 |
Ohh okayy. I forgot to look in the closed PR's section! |
What Dev Docs changes are you proposing?
Toward the end of the article, this sentence was repeated twice:
https://www.asyncapi.com/docs/getting-started/event-driven-architectures
However, that's not always the case, as Martin Fowler explains in his talk "the many meanings of Event-Driven Architecture":
Code of Conduct
The text was updated successfully, but these errors were encountered: