Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[📑 Docs]: found one duplicate paragraph in docs #779

Closed
1 task done
yy185058 opened this issue May 18, 2022 · 21 comments
Closed
1 task done

[📑 Docs]: found one duplicate paragraph in docs #779

yy185058 opened this issue May 18, 2022 · 21 comments

Comments

@yy185058
Copy link

What Dev Docs changes are you proposing?

Toward the end of the article, this sentence was repeated twice:
https://www.asyncapi.com/docs/getting-started/event-driven-architectures

However, that's not always the case, as Martin Fowler explains in his talk "the many meanings of Event-Driven Architecture":

Code of Conduct

  • I agree to follow this project's Code of Conduct
@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@pratik9315
Copy link
Contributor

Hey! I think you forgot to give title to your PR!

@yy185058 yy185058 changed the title [📑 Docs]: [📑 Docs]: found one duplicate paragraph in docs May 18, 2022
@yy185058
Copy link
Author

@pratik2315 thanks! just added it!

@starlightknown
Copy link
Contributor

hey are you working on this issue? or I would like to work on it please

@quetzalliwrites
Copy link
Member

@starlightknown go ahead and start a PR 👍🏻 😄

@yy185058
Copy link
Author

are we allowed to raise a PR for changes ourselves?

@quetzalliwrites
Copy link
Member

quetzalliwrites commented May 19, 2022

@yy185058 Yes! That is how OSS works ❤️

Anyone can open an issue for a contribution proposal and then do the work with a PR. You just cannot get your change merged until core maintainers in this OSS project approve your PR.

If you want to fix this, then just let me know so that we don't confuse poor @starlightknown 😆

@yy185058
Copy link
Author

thank you for your reply! yes I can try to fix this

@quetzalliwrites
Copy link
Member

OK sounds great! If you get stuck let us know @yy185058 ...

sorry for the confusion @starlightknown! It looks like Yimin is going to do a PR.

@yy185058
Copy link
Author

Hey I was trying to raise a PR but saw this issue:

> git push -u origin fix-docs
ERROR: Permission to asyncapi/website.git denied to yy185058.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@pratik9315
Copy link
Contributor

pratik9315 commented May 20, 2022

Hey I was trying to raise a PR but saw this issue:

> git push -u origin fix-docs
ERROR: Permission to asyncapi/website.git denied to yy185058.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Hey there! Did u add upstream URL of the main repo in your forked project? Can you run a
git remote -v command to double check

@yy185058
Copy link
Author

sorry this is my first time contributing to OSS, here's what I see for that command:

$ git remote -v 
origin  git@github.com:asyncapi/website.git (fetch)
origin  git@github.com:asyncapi/website.git (push)

what I did is cloned the source code to my local and created a branch from it, and now trying to push changes from that branch

@pratik9315
Copy link
Contributor

sorry this is my first time contributing to OSS, here's what I see for that command:

$ git remote -v 
origin  git@github.com:asyncapi/website.git (fetch)
origin  git@github.com:asyncapi/website.git (push)

what I did is cloned the source code to my local and created a branch from it, and now trying to push changes from that branch

Got the error! You should also add
git remote add upstream "main repo URL"

@pratik9315
Copy link
Contributor

pratik9315 commented May 20, 2022

sorry this is my first time contributing to OSS, here's what I see for that command:

$ git remote -v 
origin  git@github.com:asyncapi/website.git (fetch)
origin  git@github.com:asyncapi/website.git (push)

what I did is cloned the source code to my local and created a branch from it, and now trying to push changes from that branch

You have set up the main repo on your local machine you should set up the forked repo on your pc and then perform the git remote add upstream URL I mentioned above

@yy185058
Copy link
Author

yy185058 commented May 20, 2022

thank you! is this the correct flow:

  1. clone the main repo to local
  2. fork the repo and run git remote add upstream "[main repo URL](https://github.com/asyncapi/website.git)"
  3. create branch on item 2 and finish code changes
  4. push the changes and create PR

i have a feeling that this is wrong as in this case seems like the cloning repo isn't used at all...

@pratik9315
Copy link
Contributor

thank you! is this the correct flow:

  1. clone the main repo to local
  2. fork the repo and run git remote add upstream "[main repo URL](https://github.com/asyncapi/website.git)"
  3. create branch on item 2 and finish code changes
  4. push the changes and create PR

i have a feeling that this is wrong as in this case seems like the cloning repo isn't used at all...

  1. Fork the repo
  2. Clone the "forked repo" into your local machine (not the main repo haha!)
  3. Perform the git remote add upstream (https://github.com/asyncapi/website.git)
  4. Create a branch and submit changes
  5. Push the changes😄

@akshatnema
Copy link
Member

After reading this issue, I think there is a need to work on #748. What do you think @alequetzalli?

@starlightknown starlightknown removed their assignment May 20, 2022
@yy185058
Copy link
Author

thank you so much for the patience, I just had my PR raised!

@pratik9315
Copy link
Contributor

Hello there @yy185058. You sure? I cannot see your PR listed anywhere😅!

@starlightknown
Copy link
Contributor

starlightknown commented May 25, 2022

They haven't linked this issue in their PR @pratik2315
And it got closed because another PR was already there and it's merged now. This issue can be closed since it's solved now

@pratik9315
Copy link
Contributor

pratik9315 commented May 25, 2022

Ohh okayy. I forgot to look in the closed PR's section!
Thanks for clarifying @starlightknown 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 🚀
Development

No branches or pull requests

5 participants