No functions to access message and operation traits

[jonaslagoni]

Reason/Context

Even though we provide access to message and operation traits if listed in the components sections, there exist no functions on the operation and message objects themselves to access traits if you use the parser with the option applyTraits = false.

Description

I would expect functions such as the following to be available:
Message trait: asyncapi.channel('mychannel').publish().message().traits();
Operation trait: asyncapi.channel('mychannel').publish().traits();

It is possible to access the traits using the following
Message trait: asyncapi.channel('mychannel').publish().message()._json.traits
Operation trait: asyncapi.channel('mychannel').publish()._json.traits

Up for discussion:
If the traits are already applied, would you really want access to the original traits 🤔 ?

[derberg]

If the traits are already applied, would you really want access to the original traits 🤔 ?

This was exactly my question after reading the context section. What is the use case here really?

[jonaslagoni]

@derberg You wouldn't IMO, however as stated you have no way to access those traits (without accessing the underlying json schema) if you for example parse an AsyncAPI document with the option applyTraits = false.

[derberg]

oh, you found the use case, if we allow applyTraits = false we should also enable easy access to traits

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

[magicmatatjahu]

@derberg @jonaslagoni We have option to access to traits by x-parser-original-traits extension here, so we only must write API for that :)

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

[KhudaDad414]

@magicmatatjahu if someone wants to access traits with {applyTraits: false} then there won't be any x-parser-original-traits there. so the core issue is still there. can I add these two functions? I really need them right now :)

[magicmatatjahu]

@KhudaDad414 Exactly, won't be, but will be the native traits object :) The traits object is only deleted with {applyTraits: true} (code), so you should check first the x-parser-original-traits extension and then as a fallback check the traits field :) You can create PR, if you asked for it :)

[asyncapi-bot]

🎉 This issue has been resolved in version 1.9.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀