Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many functions assume an integer cast-able epsiode_key #6

Open
astrowonk opened this issue Jan 19, 2023 · 0 comments
Open

Too many functions assume an integer cast-able epsiode_key #6

astrowonk opened this issue Jan 19, 2023 · 0 comments

Comments

@astrowonk
Copy link
Owner

I should probably have an assert on the integerness of episode_key when trying to search in an episode range or order by the episode key rather than the search score.

Right now, my understanding is that CAST('episode400' as int) will return 0 so the sorting just won't do anything. It does order by episode_key, score so if the episode_key searching does nothing you'll just get it by score, but it doesn't say anywhere that 'whoops casting the episode key to integer isn't working.'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant