You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
azure key vault adds a - between the key prefix and the secret name when it reads it from azure key vault. It does this even when the key prefix is "" so secrets end up named -my-secret instead of my-secret.
To Reproduce
Follow the instructions to set up an azure key vault integrated install with a connections_prefix of "".
Create a secret named -my-var in azure key vault.
Use the example dag provided in the docs with Variable.get("my-var")
You will see that it fetches the variable because it is incorrectly mapping my-var to -my-var instead of my-var.
Expected Behavior
connections_prefix and variables_prefix dont add a leading - when they are set to "".
Additional context
From my understanding null his historically not been supported as a value for that even though its passed as a JSON blob? Might be more idiomatic but if this is changed I'd think all providers should be changed. I suggest we don't do it and just continue to use "" but fix our prefixing as described in this ticket.
The text was updated successfully, but these errors were encountered:
Doc fix filed at https://github.com/astronomer/issues/issues/4796 intentionally updates docs to match the current (pre-fix) behavior of this provider. Once this ticket is done, the docs should be updated again to state the behavior changes with Airflow v. .
Describe the bug
azure key vault adds a - between the key prefix and the secret name when it reads it from azure key vault. It does this even when the key prefix is "" so secrets end up named -my-secret instead of my-secret.
To Reproduce
Follow the instructions to set up an azure key vault integrated install with a connections_prefix of "".
Create a secret named -my-var in azure key vault.
Use the example dag provided in the docs with Variable.get("my-var")
You will see that it fetches the variable because it is incorrectly mapping my-var to -my-var instead of my-var.
Expected Behavior
connections_prefix and variables_prefix dont add a leading - when they are set to "".
Additional context
From my understanding null his historically not been supported as a value for that even though its passed as a JSON blob? Might be more idiomatic but if this is changed I'd think all providers should be changed. I suggest we don't do it and just continue to use "" but fix our prefixing as described in this ticket.
The text was updated successfully, but these errors were encountered: