-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does uv honor the no-manylinux install flags? #5915
Comments
The relevant section of the PEP is
As far as I know, we don't support this yet. |
Thank you for the quick response and confirmation! |
We can consider supporting it! |
Actually, I think I'm wrong — we do have code to check for this uv/crates/uv-python/python/packaging/_manylinux.py Lines 181 to 204 in dd7da6a
I'm not sure if we're not properly enforcing it. Is it possible you're getting a cached build? |
@zanieb -- I think that's pulled in from the vendored packaging code. It doesn't look like we actually call it though. |
Ah we generate the compatible platform tags directly in Rust? |
Yeah, we wrote a |
Agree we should support it per the spec though. |
Thanks for investigating. |
I ran an install of
|
@harmstyler do you happen to know a package that's faster to build than
actually 2x, not sure if there's an easy way to test this based on the output 😢 |
Maybe uamqp? |
We might just want to write a unit test instead of an integration test. I think we need to test various |
good call - added a unit test 🌵 |
PIP honors a flag for disabling the use of manylinux pre-built whl files. When I use uv and the no-manylinux package, my build finishes in seconds (yay), but that makes me think that uv is not building the manylinux whl files itself, as my normal pip install takes an hour.
https://peps.python.org/pep-0600/
https://github.com/asottile-archive/no-manylinux/blob/main/_manylinux.py
The text was updated successfully, but these errors were encountered: