Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv version in cache key #203

Closed
nijel opened this issue Dec 20, 2024 · 1 comment · Fixed by #206
Closed

uv version in cache key #203

nijel opened this issue Dec 20, 2024 · 1 comment · Fixed by #206

Comments

@nijel
Copy link

nijel commented Dec 20, 2024

With the recent move to enable caching by default, the cache lifetime might be more a question.

The cache key currently includes uv version. As uv is a quickly moving target (2 releases a week) and the action always using the latest version (unless a specific one is pinned), this effectively discards the cache every couple of days.

I know there were some situations in the past when CI cache pruning corrupted cache, but generally the cache should be compatible between uv releases.

Maybe it's time to reconsider this part of the cache key?

@eifinger
Copy link
Collaborator

That's a good idea! The mechanism was carried over from setup-rye and now that uv makes sure to detect old version caches we do not need this anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants