Consider removing PD901

[charliermarsh]

PD901 disallows df as a variable name. This is an opinionated rule in pandas-vet so is typically only enabled via explicit opt-in. But we don't have that behavior for 900-level rules, so it's always enabled if you enable PD. The rule is overly strict for most cases, so I think it's a net-negative to have it in Ruff given our behavior.

[dhruvmanila]

I'm in favor of this 👍

[zanieb]

@charliermarsh can you fill this issue in?

[kdebrab]

AFAICT, it seems like rule PD901 has not been deprecated?

[dhruvmanila]

Yeah, it wasn't removed. cc @charliermarsh

[charliermarsh]

I don't think I closed it! But I'll re-open.

[zanieb]

Can you fill in the context on why we should consider removing the rule?

[charliermarsh]

Sure.