Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noqa is flake8 specific keyword, ruff should have its own #4669

Open
copdips opened this issue May 26, 2023 · 2 comments
Open

noqa is flake8 specific keyword, ruff should have its own #4669

copdips opened this issue May 26, 2023 · 2 comments
Labels
suppression Related to supression of violations e.g. noqa

Comments

@copdips
Copy link

copdips commented May 26, 2023

if I accedently have flake8 enabled, sometimes it's enable dby the IDE itself globally, or a collegue opens the code base from his IDE, as ruff noqa has its own error code (for e.g. AGR001 here) that flake8 is not aware. We can see some unexpected IDE warning:

image

Is it possible to create new ruff specific noqa keyword ? maybe noruff ?

@charliermarsh
Copy link
Member

We're probably going to redo suppression comments more holistically, so I'd like to hold off on making any incremental changes in the meantime, but I'm going to keep this open since it's a relevant issue for us to resolve with any improved design.

@charliermarsh charliermarsh added the suppression Related to supression of violations e.g. noqa label May 26, 2023
@evanrittenhouse
Copy link
Contributor

Relevant discussion: #4051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suppression Related to supression of violations e.g. noqa
Projects
None yet
Development

No branches or pull requests

3 participants