Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-pack test is unreliable #1425

Closed
charliermarsh opened this issue Dec 28, 2022 · 7 comments
Closed

wasm-pack test is unreliable #1425

charliermarsh opened this issue Dec 28, 2022 · 7 comments
Labels
internal An internal refactor or improvement

Comments

@charliermarsh
Copy link
Member

See: https://github.com/charliermarsh/ruff/actions/runs/3794761527/jobs/6453331265.

@squiddy
Copy link
Contributor

squiddy commented Dec 28, 2022

What I don't understand - and I noticed that in multiple runs - is why the operation is being canceled. Many times the tests succeeded.

running 3 tests

test ruff::lib_wasm::test::empty_config ... ok
test ruff::lib_wasm::test::partial_config ... ok
test ruff::lib_wasm::test::partial_nested_config ... ok

test result: ok. 3 passed; 0 failed; 0 ignored

Error: The operation was canceled.

@charliermarsh
Copy link
Member Author

Yeah, trying to find any relevant issues etc. but not seeing anything.

@charliermarsh
Copy link
Member Author

I don't know if this is just a symptom of a different failure, but when it fails in this way, we never see the other test suites skip execution:

Screen Shot 2022-12-28 at 10 24 08 AM

Screen Shot 2022-12-28 at 10 24 12 AM

@charliermarsh
Copy link
Member Author

I'll try setting --lib for now... I dunno.

@squiddy
Copy link
Contributor

squiddy commented Dec 28, 2022

I'm also seeing this.. which isn't that helpful. I was thinking that maybe it's just being canceled because a new workflow was scheduled, but that doesn't seem to be the case.
I would also kinda rule out memory issues, we're not even running headless browsers for testing..

2022-12-28T15:22:07.1731677Z running 3 tests
2022-12-28T15:22:07.1831067Z 
2022-12-28T15:22:07.2165473Z test ruff::lib_wasm::test::empty_config ... ok
2022-12-28T15:22:07.2217990Z test ruff::lib_wasm::test::partial_config ... ok
2022-12-28T15:22:07.2433964Z test ruff::lib_wasm::test::partial_nested_config ... ok
2022-12-28T15:22:07.2457576Z 
2022-12-28T15:22:07.2459785Z test result: ok. 3 passed; 0 failed; 0 ignored
2022-12-28T15:22:07.2460027Z 
2022-12-28T15:22:41.4902290Z ##[error]Process completed with exit code 143.
2022-12-28T15:22:41.4984194Z ##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

@squiddy
Copy link
Contributor

squiddy commented Dec 28, 2022

Well, actually.. when you start searching for the "shutdown signal" thing, numerous issues popup about people's jobs being canceled. Most often due to resource limits.

For example: actions/runner-images#6680
One response: actions/runner-images#6680 (comment)

@charliermarsh charliermarsh added bug Something isn't working internal An internal refactor or improvement labels Dec 28, 2022
@charliermarsh charliermarsh removed the bug Something isn't working label Feb 17, 2023
@MichaReiser
Copy link
Member

I don't remember having seen this in months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

No branches or pull requests

3 participants