Additional comment to noqa added by ruff

[ashrub-holvi]

Hi!

Ruff can automatically add noqa directives, but they don't have any info about how they were added:

  # noqa: S308

and it may be difficult to distinguish intentionally/manually added noqa and those automatically added.

I think, main use case is migration to ruff for existing codebase without fixing everything at once, but it should be clear that those noqa added automatically and should be handled at some point, something like that:

  # noqa: S308 FIXME when you are here

Downside of it - adding longer comment will produce more formatting changes, so, perhaps

  # noqa: S308 auto

or even ruff may have some argument for provide the text of comment.

[kaddkaka]

Do you really want to # noqa them if you intend to fix them?

In our CI we have say 10000 ruff lint violations, and we accept if this number shrinks but fail if it ever increases.

[ashrub-holvi]

Do you really want to # noqa them if you intend to fix them?

Yes, first of all it makes it much more visible - when you read the code you see that lines you are touching can be improved - ruff is working on file level, so linter can show issues in lines you are not intended to touch. Also, marking all existing issues as noqa really simplifies to see new issues, approach with number of errors also may work in average, but same time it might be you fixed two old, but introduced a new.
Something like #1149 may also be useful.

[kaddkaka]

Thanks now I understand the situation much better. For me #1149 would be a more valuable feature.

If you really want to do this it can be done using ruff+other tool.

Example on how to achieve this today with ruff+git+vim:

$ ruff check --add-noqa
$ git jump diff 
:cdo normal! A (added automatically by ruff) 

Perhaps this eliminates the feature need in ruff?