Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose details on devices marked for deletion #881

Closed
davidebriani opened this issue Nov 29, 2023 · 1 comment · Fixed by #882
Closed

Expose details on devices marked for deletion #881

davidebriani opened this issue Nov 29, 2023 · 1 comment · Fixed by #882
Labels
app:appengine_api This issue or pull request is about astarte_appengine_api application

Comments

@davidebriani
Copy link
Collaborator

davidebriani commented Nov 29, 2023

Astarte supports deleting devices, as described in issue #392.
However when a device is marked for deletion, this information is not exposed by Astarte APIs: e.g. the device still appear in the device list when querying Appengine for the list.

The current behavior leads to both an odd UX and external systems not being able to rely on a consistent source of truth.
By exposing whether a device is marked for deletion would allow systems that are based on Astarte (e.g. Astarte Dashboard) to distinguish it from the other devices.

@davidebriani davidebriani added the app:appengine_api This issue or pull request is about astarte_appengine_api application label Nov 29, 2023
@davidebriani
Copy link
Collaborator Author

Besides exposing the device details, an additional argument could be considered for the query to list devices in order to filter the list and return only the devices not marked for deletion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:appengine_api This issue or pull request is about astarte_appengine_api application
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant