fix: using db.exists and get_value instead of get_doc

asoral · Sep 29, 2021 · 3337afe · 3337afe
1 parent 4536ab2
commit 3337afe
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/erpnext/erpnext_integrations/doctype/taxjar_settings/taxjar_settings.py b/erpnext/erpnext_integrations/doctype/taxjar_settings/taxjar_settings.py
@@ -25,9 +25,9 @@ def on_update(self):
 
 		custom_fields = []
 		for dt in ['Item', 'Sales Invoice Item']:
-			doc = frappe.get_doc('Custom Field', {'dt': dt, 'fieldname':'product_tax_category'})
+			doc = frappe.db.exists('Custom Field', {'dt': dt, 'fieldname':'product_tax_category'})
 			custom_fields.append(doc)
-			fields_hidden = doc.get('hidden') if doc else 0
+			fields_hidden = frappe.db.get_value('Custom Field', {'dt': dt, 'fieldname':'product_tax_category'},'hidden')
 		fields_already_exist = True if custom_fields else False