From bbded5de258ab86d040b4901faf9642aeb88eed1 Mon Sep 17 00:00:00 2001
From: Brett <brettgraham@gmail.com>
Date: Wed, 15 Mar 2023 13:16:47 -0400
Subject: [PATCH] add upper pin to jsonschema

jsonschema 4.18 will introduce changes that are incompatible
with asdf. More details can be found in:
https://github.com/asdf-format/asdf/issues/1485
this commit adds an upper pin to jsoncschema and removes
it from the devdeps testing
an issue was created to track removal of the pin:
https://github.com/asdf-format/asdf/issues/1486
---
 CHANGES.rst          | 1 +
 pyproject.toml       | 2 +-
 requirements-dev.txt | 3 ++-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/CHANGES.rst b/CHANGES.rst
index 0bf07a9e7..ad6be06b4 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -43,6 +43,7 @@ The ASDF Standard is at v1.6.0
 - Deprecate asdf.tests.helpers [#1440]
 - respect umask when determining file permissions for written files [#1451]
 - rename master branch to main [#1479]
+- require jsonschema<4.18 [#1487]
 
 2.14.3 (2022-12-15)
 -------------------
diff --git a/pyproject.toml b/pyproject.toml
index a6f12b323..6f054fdb0 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -25,7 +25,7 @@ dependencies = [
   "importlib-metadata>=4.11.4",
   'importlib_resources>=3; python_version < "3.9"',
   "jmespath>=0.6.2",
-  "jsonschema>=4.0.1",
+  "jsonschema<4.18,>=4.0.1", # jsonschema 4.18 contains incompatible changes: https://github.com/asdf-format/asdf/issues/1485
   "numpy>=1.20",
   'numpy<1.25,>=1.20; python_version < "3.9"',
   "packaging>=19",
diff --git a/requirements-dev.txt b/requirements-dev.txt
index 85f8b5eea..a9136d580 100644
--- a/requirements-dev.txt
+++ b/requirements-dev.txt
@@ -7,7 +7,8 @@ git+https://github.com/asdf-format/asdf-wcs-schemas
 git+https://github.com/astropy/astropy
 git+https://github.com/spacetelescope/gwcs
 git+https://github.com/yaml/pyyaml.git
-git+https://github.com/python-jsonschema/jsonschema
+# jsonschema 4.18 contains incompatible changes: https://github.com/asdf-format/asdf/issues/1485
+#git+https://github.com/python-jsonschema/jsonschema
 
 scipy>=0.0.dev0
 numpy>=0.0.dev0 ; python_version > "3.8"