-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rendering a PDF emits warning with 1.5.8 #707
Comments
I forgot to give you a heads up about this. Asciidoctor 1.5.8 no longer uses thread_safe. That gem has been deprecated. It now uses concurrent-ruby. It provides the same functionality, but does not offer a compatible API. For details, see asciidoctor/asciidoctor#2822. |
So do you think we need a new release? I guess we will have to keep thread_safe in the asciidoctorj.jar because asciidoctorj-pdf relies on it being available. |
Yes, I think it's worth it.
Correct. Both are currently needed. |
Fixed with 1.5.8.1 |
When rendering a PDF with the latest 1.5.8 I get a warning:
Apparently I forgot to add this gem.
@mojavelinux Is this critical? Should I prepare a 1.5.8.1 release?
The text was updated successfully, but these errors were encountered: