From b7b2f74bfe74e3131c54e8fcb9cbcac9788fb742 Mon Sep 17 00:00:00 2001 From: Seth Axen Date: Tue, 1 Nov 2022 15:42:06 +0100 Subject: [PATCH 1/5] Transpose diverging to expected order --- arviz/plots/traceplot.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arviz/plots/traceplot.py b/arviz/plots/traceplot.py index f6113b948a..f8dbde5ad8 100644 --- a/arviz/plots/traceplot.py +++ b/arviz/plots/traceplot.py @@ -174,7 +174,9 @@ def plot_trace( divergences = "top" if rug else "bottom" if divergences: try: - divergence_data = convert_to_dataset(data, group="sample_stats").diverging + divergence_data = convert_to_dataset(data, group="sample_stats").diverging.transpose( + "chain", "draw" + ) except (ValueError, AttributeError): # No sample_stats, or no `.diverging` divergences = None From 0d2d8165bdb496c267bf36d4eaf99ee43286a55a Mon Sep 17 00:00:00 2001 From: Seth Axen Date: Tue, 1 Nov 2022 15:42:35 +0100 Subject: [PATCH 2/5] Add test for correct behavior --- arviz/tests/base_tests/test_plots_matplotlib.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arviz/tests/base_tests/test_plots_matplotlib.py b/arviz/tests/base_tests/test_plots_matplotlib.py index 0dbf9ecfa2..d74271aa92 100644 --- a/arviz/tests/base_tests/test_plots_matplotlib.py +++ b/arviz/tests/base_tests/test_plots_matplotlib.py @@ -294,6 +294,12 @@ def test_plot_trace_invalid_varname_warning(models, kwargs): assert axes.shape +def test_plot_trace_diverging_correctly_transposed(): + idata = load_arviz_data("centered_eight") + idata.sample_stats["diverging"] = idata.sample_stats.diverging.T + plot_trace(idata, diverging=True) + + @pytest.mark.parametrize( "bad_kwargs", [{"var_names": ["mu", "tau"], "lines": [("mu", {}, ["hey"])]}] ) From 776d7de922f2d9b839e4bf72fefe7ae801c39477 Mon Sep 17 00:00:00 2001 From: Seth Axen Date: Tue, 1 Nov 2022 19:04:13 +0100 Subject: [PATCH 3/5] Use correct keyword argument --- arviz/tests/base_tests/test_plots_matplotlib.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arviz/tests/base_tests/test_plots_matplotlib.py b/arviz/tests/base_tests/test_plots_matplotlib.py index d74271aa92..8fad67e249 100644 --- a/arviz/tests/base_tests/test_plots_matplotlib.py +++ b/arviz/tests/base_tests/test_plots_matplotlib.py @@ -297,7 +297,7 @@ def test_plot_trace_invalid_varname_warning(models, kwargs): def test_plot_trace_diverging_correctly_transposed(): idata = load_arviz_data("centered_eight") idata.sample_stats["diverging"] = idata.sample_stats.diverging.T - plot_trace(idata, diverging=True) + plot_trace(idata, divergences="bottom") @pytest.mark.parametrize( From b81c0388d753fdce978409235b6c5840c66885b5 Mon Sep 17 00:00:00 2001 From: Seth Axen Date: Tue, 1 Nov 2022 19:06:19 +0100 Subject: [PATCH 4/5] Add new Changelog headers --- CHANGELOG.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a2a8f05f0d..6aa613330e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,15 @@ # Change Log +## v0.x.x Unreleased + +### New features + +### Maintenance and fixes + +### Deprecation + +### Documentation + ## v0.13.0 (2022 Oct 22) ### New features From 8e7c4b5ccf6157193a15837a35164dd14b8c3129 Mon Sep 17 00:00:00 2001 From: Seth Axen Date: Tue, 1 Nov 2022 19:07:22 +0100 Subject: [PATCH 5/5] Add changelog entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6aa613330e..c1c210dce4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ ### New features ### Maintenance and fixes +- Fix dimension ordering for `plot_trace` with divergences ([2151](https://github.com/arviz-devs/arviz/pull/2151)) ### Deprecation