Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated arguments from plot_pair() #2073

Closed
agustinaarroyuelo opened this issue Jul 24, 2022 · 3 comments · Fixed by #2085
Closed

Remove deprecated arguments from plot_pair() #2073

agustinaarroyuelo opened this issue Jul 24, 2022 · 3 comments · Fixed by #2085
Labels
Beginner User Documentation Documentation outside of the codebase
Milestone

Comments

@agustinaarroyuelo
Copy link
Contributor

plot_kwargs is an argument of plot_pair() yet it is not described in the documentation for this function.

To Reproduce
Go to the link and search for the description of plot_kwargs

Expected behavior
A complete docstring were plot_kwargs usage and behaviour is described.

@OriolAbril
Copy link
Member

It might also be possible it is not even used at all, in which case it should be removed instead of documented

@agustinaarroyuelo
Copy link
Contributor Author

You are right, we planned to deprecate plot_kwargs (see here) Maybe we can move forward with it instead of documenting

@OriolAbril
Copy link
Member

Let's remove it then and update the issue to remove the deprecated arguments in plot_pair. I am also adding it to the v0.13 milestone.

@OriolAbril OriolAbril added this to the v0.13 milestone Jul 24, 2022
@OriolAbril OriolAbril changed the title Missing documentation for plot_kwargs argument in plot_pair() Remove depredated arguments from plot_pair() Jul 24, 2022
@agustinaarroyuelo agustinaarroyuelo changed the title Remove depredated arguments from plot_pair() Remove deprecated arguments from plot_pair() Aug 1, 2022
@OriolAbril OriolAbril linked a pull request Aug 6, 2022 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beginner User Documentation Documentation outside of the codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants