Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain naming convention in sample_stats #1053

Closed
OriolAbril opened this issue Feb 7, 2020 · 5 comments · Fixed by #1063
Closed

Explain naming convention in sample_stats #1053

OriolAbril opened this issue Feb 7, 2020 · 5 comments · Fixed by #1063
Labels
User Documentation Documentation outside of the codebase

Comments

@OriolAbril
Copy link
Member

The section on sample stats group in InferenceData scheme is missing a description of the naming convention and what does every variable represents.

The bullet points should be extended with variables still missing and all explanations added/improved. After this is done, it may be interesting to have something like SUPPORTED_GROUPS for sample stats variables.

@OriolAbril OriolAbril added the User Documentation Documentation outside of the codebase label Feb 7, 2020
@nitishp25
Copy link
Contributor

nitishp25 commented Feb 9, 2020

Hi @OriolAbril, I found the PyMC3 sampler statistics description. Can I update the current descriptions with these ones?

@OriolAbril
Copy link
Member Author

This is a good start! Good work, thanks

There are some things to be noted before starting: different libraries, different samplers and schema specification style.

First is to use ArviZ names, most will be the same, but some will differ (e.g. model_logp -> lp) it is currently not explained anywhere so you'll have to read io_pymc3 and io_pystan to check the name used in ArviZ and that the name convention is coherent (maybe some less used quantities keep different names depending on the original inference library).

Then, ArviZ also has to account for the multiple samplers available (if you check the end of the page you linked you'll see that Metropolis has some different sample_stats).

And finally, the schema specification should ideally be clear and concise, thus, I think we should only describe the variable, not explain how is is used/why is it useful (which should be explained in the educational material).

@nitishp25
Copy link
Contributor

@ahartikainen can you please explain what n_leapfrog describes?

@ahartikainen
Copy link
Contributor

Hi, see https://mc-stan.org/docs/2_22/reference-manual/hmc-algorithm-parameters.html

NUTS and its Configuration
The no-U-turn sampler (NUTS) automatically selects an appropriate number of leapfrog steps in each iteration in order to allow the proposals to traverse the posterior without doing unnecessary work.

@nitishp25
Copy link
Contributor

Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Documentation Documentation outside of the codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants