hokusai review_app create implicitly forces docker tag to be review-app name.

[artsyjian]

$ hokusai version
0.5.12

$ hokusai review_app create --help
Usage: hokusai review_app create [OPTIONS] APP_NAME

  Creates the Kubernetes based resources defined in ./hokusai/{APP_NAME}.yml

Options:
  -v, --verbose  Verbose output
  -h, --help     Show this message and exit.

That leads one to believe that hokusai takes docker image tag from spec yml. However, in reality, the tag is hardcoded to be the app's name.

I had a use case where I wanted to use an already-existent tag that is not named after a review app. I was testing review_app commands (for k8s version update) on Force. I did not have a Force docker image locally, and due to the large image size, I did not want to build one for merely testing the create command. I just wanted to test that hokusai can spin up the deployment, whatever the tag. So I edited test-review-app.yml to specify staging as the image tag, thinking that hokusai would use that tag, but it didn't, because of the hardcoding.

I wonder what the reason is to have a tag param at all, since spec yml is required for the create command. If we maintain the param, perhaps we should expose it in the cli?