From 1f7ca4b33d599600f0042ed004207677c5ebc9c9 Mon Sep 17 00:00:00 2001 From: Simon Vergauwen Date: Mon, 16 Jan 2023 10:43:59 +0100 Subject: [PATCH 1/2] Re-add check --- .github/workflows/pull_request.yml | 33 ++----------------- .../kotlin/arrow/core/continuations/Effect.kt | 26 +++++++-------- 2 files changed, 16 insertions(+), 43 deletions(-) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index dccb7773060..35a24f94733 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -112,10 +112,10 @@ jobs: with: arguments: compileTestKotlin - - name: jvmTest + - name: check uses: gradle/gradle-build-action@v2 with: - arguments: jvmTest + arguments: check - name: Create code coverage report if: "! github.event.pull_request.head.repo.fork " @@ -137,34 +137,7 @@ jobs: if: failure() uses: actions/upload-artifact@v3 with: - name: 'reports-jvm' - path: '**/build/reports/**' - - js: - runs-on: ubuntu-latest - timeout-minutes: 60 - - steps: - - uses: actions/checkout@v3 - with: - fetch-depth: 0 - - - name: Set up Java - uses: actions/setup-java@v3 - with: - distribution: 'zulu' - java-version: 11 - - - name: jsTest - uses: gradle/gradle-build-action@v2 - with: - arguments: jsTest --info - - - name: Upload reports - if: failure() - uses: actions/upload-artifact@v3 - with: - name: 'reports-js' + name: 'reports' path: '**/build/reports/**' linux: diff --git a/arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/continuations/Effect.kt b/arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/continuations/Effect.kt index e0e3e67f45d..fd3c5daa6a3 100644 --- a/arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/continuations/Effect.kt +++ b/arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/continuations/Effect.kt @@ -26,19 +26,19 @@ import kotlin.coroutines.resumeWithException * * - * [Writing a program with Effect](#writing-a-program-with-effect) - * [Handling errors](#handling-errors) - * [Structured Concurrency](#structured-concurrency) - * [Arrow Fx Coroutines](#arrow-fx-coroutines) - * [parZip](#parzip) - * [parTraverse](#partraverse) - * [raceN](#racen) - * [bracketCase / Resource](#bracketcase--resource) - * [KotlinX](#kotlinx) - * [withContext](#withcontext) - * [async](#async) - * [launch](#launch) - * [Leaking `shift`](#leaking-shift) + * [Writing a program with Effect](#writing-a-program-with-effect) + * [Handling errors](#handling-errors) + * [Structured Concurrency](#structured-concurrency) + * [Arrow Fx Coroutines](#arrow-fx-coroutines) + * [parZip](#parzip) + * [parTraverse](#partraverse) + * [raceN](#racen) + * [bracketCase / Resource](#bracketcase--resource) + * [KotlinX](#kotlinx) + * [withContext](#withcontext) + * [async](#async) + * [launch](#launch) + * [Leaking `shift`](#leaking-shift) * * From 29c2325ce3bbaf1c9b74bd45a6d559d857932b86 Mon Sep 17 00:00:00 2001 From: Simon Vergauwen Date: Mon, 16 Jan 2023 14:55:33 +0100 Subject: [PATCH 2/2] Use check -x linuxX64Test -x jsTest --- .github/workflows/pull_request.yml | 33 +++++++++++++++++++++++++++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 35a24f94733..3e0c070e146 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -87,7 +87,7 @@ jobs: name: 'reports-windows' path: '**/build/reports/**' - jvm: + check: runs-on: ubuntu-latest timeout-minutes: 60 @@ -115,7 +115,7 @@ jobs: - name: check uses: gradle/gradle-build-action@v2 with: - arguments: check + arguments: check -x linuxX64Test -x jsTest - name: Create code coverage report if: "! github.event.pull_request.head.repo.fork " @@ -137,7 +137,34 @@ jobs: if: failure() uses: actions/upload-artifact@v3 with: - name: 'reports' + name: 'reports-jvm' + path: '**/build/reports/**' + + js: + runs-on: ubuntu-latest + timeout-minutes: 60 + + steps: + - uses: actions/checkout@v3 + with: + fetch-depth: 0 + + - name: Set up Java + uses: actions/setup-java@v3 + with: + distribution: 'zulu' + java-version: 11 + + - name: jsTest + uses: gradle/gradle-build-action@v2 + with: + arguments: jsTest + + - name: Upload reports + if: failure() + uses: actions/upload-artifact@v3 + with: + name: 'reports-js' path: '**/build/reports/**' linux: