Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ping-pong test, connect(), and lack of error messages #19

Closed
LeeTibbert opened this issue Sep 4, 2022 · 3 comments
Closed

ping-pong test, connect(), and lack of error messages #19

LeeTibbert opened this issue Sep 4, 2022 · 3 comments

Comments

@LeeTibbert
Copy link
Collaborator

LeeTibbert commented Sep 4, 2022

Discovered in the TcpSuite server-client ping-pong test, but probably generally applicable.

connect(foo) needs to give some indication of error, perhaps Throwing
when the connection fails.

Later:
I see that /EpollAsyncSocketChannel.scala has two places
where it throws ConnectException("Connection refused").
If I can create time, I will have to check why those did not
trigger.

The problem may be that it does so currently and that something in the
peer-to-peer test is not letting that message propagate to the user.

@LeeTibbert LeeTibbert changed the title peer-to-peer test, connect(), and lack of error messages ping-pong test, connect(), and lack of error messages Sep 4, 2022
@LeeTibbert
Copy link
Collaborator Author

Later: Debugging writes reveal that a proper & expected ConnectException is being thrown
about line 236 in EpollAsyncSocketChannel.scala and never showing up to interrupt the
test or even being reported.

More later, shift over.

@armanbilge
Copy link
Owner

Is this issue resolved as of #31?

@LeeTibbert
Copy link
Collaborator Author

Yes it is. Thank you for that fix and this bookkeeping

For the future:
Resolution is that the ConectException was being thrown but it took 2 minutes or so
for the TCP SYN connection handshake to timeout and then throw. That Exception
was then being ignored by the test, making it look like the ConnectException never
happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants