Skip to content

Commit

Permalink
Merge pull request paper-trail-gem#1120 from paper-trail-gem/events
Browse files Browse the repository at this point in the history
Extract `Events` module
  • Loading branch information
jaredbeck authored Jul 24, 2018
2 parents 6ab2e93 + 84368ea commit ac710b3
Show file tree
Hide file tree
Showing 8 changed files with 494 additions and 340 deletions.
273 changes: 273 additions & 0 deletions lib/paper_trail/events/base.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,273 @@
# frozen_string_literal: true

module PaperTrail
module Events
# We refer to times in the lifecycle of a record as "events". There are
# three events:
#
# - create
# - `after_create` we call `RecordTrail#record_create`
# - update
# - `after_update` we call `RecordTrail#record_update`
# - `after_touch` we call `RecordTrail#record_update`
# - `RecordTrail#save_with_version` calls `RecordTrail#record_update`
# - `RecordTrail#touch_with_version` (deprecated) calls `RecordTrail#record_update`
# - `RecordTrail#update_columns` is also referred to as an update, though
# it uses `RecordTrail#record_update_columns` rather than
# `RecordTrail#record_update`
# - destroy
# - `before_destroy` or `after_destroy` we call `RecordTrail#record_destroy`
#
# The value inserted into the `event` column of the versions table can also
# be overridden by the user, with `paper_trail_event`.
#
# @api private
class Base
RAILS_GTE_5_1 = ::ActiveRecord.gem_version >= ::Gem::Version.new("5.1.0.beta1")

# @api private
def initialize(record, in_after_callback)
@record = record
@in_after_callback = in_after_callback
end

# Determines whether it is appropriate to generate a new version
# instance. A timestamp-only update (e.g. only `updated_at` changed) is
# considered notable unless an ignored attribute was also changed.
#
# @api private
def changed_notably?
if ignored_attr_has_changed?
timestamps = @record.send(:timestamp_attributes_for_update_in_model).map(&:to_s)
(notably_changed - timestamps).any?
else
notably_changed.any?
end
end

private

# Rails 5.1 changed the API of `ActiveRecord::Dirty`. See
# https://github.com/paper-trail-gem/paper_trail/pull/899
#
# @api private
def attribute_changed_in_latest_version?(attr_name)
if @in_after_callback && RAILS_GTE_5_1
@record.saved_change_to_attribute?(attr_name.to_s)
else
@record.attribute_changed?(attr_name.to_s)
end
end

# @api private
def attributes_before_change(is_touch)
Hash[@record.attributes.map do |k, v|
if @record.class.column_names.include?(k)
[k, attribute_in_previous_version(k, is_touch)]
else
[k, v]
end
end]
end

# Rails 5.1 changed the API of `ActiveRecord::Dirty`. See
# https://github.com/paper-trail-gem/paper_trail/pull/899
#
# Event can be any of the three (create, update, destroy).
#
# @api private
def attribute_in_previous_version(attr_name, is_touch)
if RAILS_GTE_5_1
if @in_after_callback && !is_touch
# For most events, we want the original value of the attribute, before
# the last save.
@record.attribute_before_last_save(attr_name.to_s)
else
# We are either performing a `record_destroy` or a
# `record_update(is_touch: true)`.
@record.attribute_in_database(attr_name.to_s)
end
else
@record.attribute_was(attr_name.to_s)
end
end

# @api private
def changed_and_not_ignored
ignore = @record.paper_trail_options[:ignore].dup
# Remove Hash arguments and then evaluate whether the attributes (the
# keys of the hash) should also get pushed into the collection.
ignore.delete_if do |obj|
obj.is_a?(Hash) &&
obj.each { |attr, condition|
ignore << attr if condition.respond_to?(:call) && condition.call(@record)
}
end
skip = @record.paper_trail_options[:skip]
changed_in_latest_version - ignore - skip
end

# Rails 5.1 changed the API of `ActiveRecord::Dirty`. See
# https://github.com/paper-trail-gem/paper_trail/pull/899
#
# @api private
def changed_in_latest_version
if @in_after_callback && RAILS_GTE_5_1
@record.saved_changes.keys
else
@record.changed
end
end

# @api private
def changes
notable_changes = changes_in_latest_version.delete_if { |k, _v|
!notably_changed.include?(k)
}
AttributeSerializers::ObjectChangesAttribute.
new(@record.class).
serialize(notable_changes)
notable_changes.to_hash
end

# Rails 5.1 changed the API of `ActiveRecord::Dirty`. See
# https://github.com/paper-trail-gem/paper_trail/pull/899
#
# @api private
def changes_in_latest_version
if @in_after_callback && RAILS_GTE_5_1
@record.saved_changes
else
@record.changes
end
end

# An attributed is "ignored" if it is listed in the `:ignore` option
# and/or the `:skip` option. Returns true if an ignored attribute has
# changed.
#
# @api private
def ignored_attr_has_changed?
ignored = @record.paper_trail_options[:ignore] + @record.paper_trail_options[:skip]
ignored.any? && (changed_in_latest_version & ignored).any?
end

# Updates `data` from the model's `meta` option and from `controller_info`.
# Metadata is always recorded; that means all three events (create, update,
# destroy) and `update_columns`.
#
# @api private
def merge_metadata_into(data)
merge_metadata_from_model_into(data)
merge_metadata_from_controller_into(data)
end

# Updates `data` from `controller_info`.
#
# @api private
def merge_metadata_from_controller_into(data)
data.merge(PaperTrail.request.controller_info || {})
end

# Updates `data` from the model's `meta` option.
#
# @api private
def merge_metadata_from_model_into(data)
@record.paper_trail_options[:meta].each do |k, v|
data[k] = model_metadatum(v, data[:event])
end
end

# Given a `value` from the model's `meta` option, returns an object to be
# persisted. The `value` can be a simple scalar value, but it can also
# be a symbol that names a model method, or even a Proc.
#
# @api private
def model_metadatum(value, event)
if value.respond_to?(:call)
value.call(@record)
elsif value.is_a?(Symbol) && @record.respond_to?(value, true)
# If it is an attribute that is changing in an existing object,
# be sure to grab the current version.
if event != "create" &&
@record.has_attribute?(value) &&
attribute_changed_in_latest_version?(value)
attribute_in_previous_version(value, false)
else
@record.send(value)
end
else
value
end
end

# @api private
def notably_changed
only = @record.paper_trail_options[:only].dup
# Remove Hash arguments and then evaluate whether the attributes (the
# keys of the hash) should also get pushed into the collection.
only.delete_if do |obj|
obj.is_a?(Hash) &&
obj.each { |attr, condition|
only << attr if condition.respond_to?(:call) && condition.call(@record)
}
end
only.empty? ? changed_and_not_ignored : (changed_and_not_ignored & only)
end

# Returns hash of attributes (with appropriate attributes serialized),
# omitting attributes to be skipped.
#
# @api private
def object_attrs_for_paper_trail(is_touch)
attrs = attributes_before_change(is_touch).
except(*@record.paper_trail_options[:skip])
AttributeSerializers::ObjectAttribute.new(@record.class).serialize(attrs)
attrs
end

# Returns an object which can be assigned to the `object_changes`
# attribute of a nascent version record. If the `object_changes` column is
# a postgres `json` column, then a hash can be used in the assignment,
# otherwise the column is a `text` column, and we must perform the
# serialization here, using `PaperTrail.serializer`.
#
# @api private
def recordable_object_changes(changes)
if PaperTrail.config.object_changes_adapter
changes = PaperTrail.config.object_changes_adapter.diff(changes)
end

if @record.class.paper_trail.version_class.object_changes_col_is_json?
changes
else
PaperTrail.serializer.dump(changes)
end
end

# Returns a boolean indicating whether to store serialized version diffs
# in the `object_changes` column of the version record.
#
# @api private
def record_object_changes?
@record.paper_trail_options[:save_changes] &&
@record.class.paper_trail.version_class.column_names.include?("object_changes")
end

# Returns an object which can be assigned to the `object` attribute of a
# nascent version record. If the `object` column is a postgres `json`
# column, then a hash can be used in the assignment, otherwise the column
# is a `text` column, and we must perform the serialization here, using
# `PaperTrail.serializer`.
#
# @api private
def recordable_object(is_touch)
if @record.class.paper_trail.version_class.object_col_is_json?
object_attrs_for_paper_trail(is_touch)
else
PaperTrail.serializer.dump(object_attrs_for_paper_trail(is_touch))
end
end
end
end
end
29 changes: 29 additions & 0 deletions lib/paper_trail/events/create.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# frozen_string_literal: true

require "paper_trail/events/base"

module PaperTrail
module Events
# See docs in `Base`.
#
# @api private
class Create < Base
# Return attributes of nascent `Version` record.
#
# @api private
def data
data = {
event: @record.paper_trail_event || "create",
whodunnit: PaperTrail.request.whodunnit
}
if @record.respond_to?(:updated_at)
data[:created_at] = @record.updated_at
end
if record_object_changes? && changed_notably?
data[:object_changes] = recordable_object_changes(changes)
end
merge_metadata_into(data)
end
end
end
end
26 changes: 26 additions & 0 deletions lib/paper_trail/events/destroy.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# frozen_string_literal: true

require "paper_trail/events/base"

module PaperTrail
module Events
# See docs in `Base`.
#
# @api private
class Destroy < Base
# Return attributes of nascent `Version` record.
#
# @api private
def data
data = {
item_id: @record.id,
item_type: @record.class.base_class.name,
event: @record.paper_trail_event || "destroy",
object: recordable_object(false),
whodunnit: PaperTrail.request.whodunnit
}
merge_metadata_into(data)
end
end
end
end
43 changes: 43 additions & 0 deletions lib/paper_trail/events/update.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
# frozen_string_literal: true

require "paper_trail/events/base"

module PaperTrail
module Events
# See docs in `Base`.
#
# @api private
class Update < Base
# - is_touch - [boolean] - Used in the two situations that are touch-like:
# - `after_touch` we call `RecordTrail#record_update`
# - `RecordTrail#touch_with_version` (deprecated) calls `RecordTrail#record_update`
# - force_changes - [Hash] - Only used by `RecordTrail#update_columns`,
# because there dirty tracking is off, so it has to track its own changes.
#
# @api private
def initialize(record, in_after_callback, is_touch, force_changes)
super(record, in_after_callback)
@is_touch = is_touch
@changes = force_changes.nil? ? changes : force_changes
end

# Return attributes of nascent `Version` record.
#
# @api private
def data
data = {
event: @record.paper_trail_event || "update",
object: recordable_object(@is_touch),
whodunnit: PaperTrail.request.whodunnit
}
if @record.respond_to?(:updated_at)
data[:created_at] = @record.updated_at
end
if record_object_changes?
data[:object_changes] = recordable_object_changes(@changes)
end
merge_metadata_into(data)
end
end
end
end
Loading

0 comments on commit ac710b3

Please sign in to comment.