-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Common filters buttons #11112
Comments
This should be achievable via #10808. |
@terrytangyuan - Awesome! @rbreeze - looks amazing! Excuse my frontend ignorance, but will this make the link open up in a new tab / reload the page? ...this.state.links.map(link => ({
title: link.name,
iconClassName: 'fa fa-external-link',
action: () => (window.location.href = link.url) If so - maybe we should add another type of link that simply changes the filter on the current view without reloading the page? WDYT? |
I think it opens up a new tab. cc @rbreeze @jiachengxu who contributed this for feedback. |
If a way of filtering without reloading the page is added by config map, it will be convenient because the filters set by the user on the UI will be maintained. However, I think it could cause confusion if the filtering button is located at the same level as the existing reload button. So it would be better to use the existed way to redirect url. |
that could be done as a field on the |
Summary
I think we should add onfigurable quick-filter buttons at the top of the workflow history view.
Something like:
Use Cases
Problem
- Re-type the filter every time. Sometimes the drop-down even misses some of the possible values (I guess due to this)
- Use browser bookmarks (local to machine / user account).
Suggested solution:
Maybe as part of the configmap I can provide something like this:
Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.
The text was updated successfully, but these errors were encountered: