From 24680b7fc8a1fd573b39d61ba7bdce5b143eb686 Mon Sep 17 00:00:00 2001
From: Saravanan Balasubramanian
 <33908564+sarabala1979@users.noreply.github.com>
Date: Tue, 7 May 2019 16:31:58 -0700
Subject: [PATCH] Fixed : Validate the secret credentials name and key (#1358)

* CheckandEstimate implementation

* fixed variable rename

* fixed gofmt

* fixed feedbacks

* Fixed Issue1355

* fixed style

* Delete e2e_temp.tmp
---
 workflow/controller/workflowpod.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/workflow/controller/workflowpod.go b/workflow/controller/workflowpod.go
index 621e1509e3b0..520ead320f18 100644
--- a/workflow/controller/workflowpod.go
+++ b/workflow/controller/workflowpod.go
@@ -946,7 +946,7 @@ func createSecretVolume(volMap map[string]apiv1.Volume, art wfv1.Artifact, keyMa
 }
 
 func createSecretVal(volMap map[string]apiv1.Volume, secret *apiv1.SecretKeySelector, keyMap map[string]bool) {
-	if secret == nil {
+	if secret == nil || secret.Name == "" || secret.Key == "" {
 		return
 	}
 	if vol, ok := volMap[secret.Name]; ok {