Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify units in osier #54

Closed
samgdotson opened this issue Apr 5, 2024 · 0 comments · Fixed by #71
Closed

simplify units in osier #54

samgdotson opened this issue Apr 5, 2024 · 0 comments · Fixed by #71
Assignees
@samgdotson
Labels
Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Style Is related to coding style guide compliance (e.g. PEP8 or google C++ style guide).

Comments

@samgdotson
Copy link
Collaborator

After releasing v3.0.0, unyt now includes common energy system units such as Wh, mmbtu, and others. Osier currently uses MW*hr instead of MWh (since it previously didn't exist).

This issue may be closed once there is a merged PR that simplifies the units in osier to match this update.
@samgdotson samgdotson added Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Style Is related to coding style guide compliance (e.g. PEP8 or google C++ style guide). labels Apr 5, 2024
@samgdotson samgdotson self-assigned this Apr 5, 2024
@samgdotson samgdotson mentioned this issue Jan 14, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samgdotson samgdotson

Labels
Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Style Is related to coding style guide compliance (e.g. PEP8 or google C++ style guide).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Logical flow samgdotson/osier
1 participant
@samgdotson