Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library name change request #5182

Closed
mathieucarbou opened this issue Sep 30, 2024 · 3 comments
Closed

Library name change request #5182

mathieucarbou opened this issue Sep 30, 2024 · 3 comments
Assignees
Labels
conclusion: invalid Issue/PR not valid topic: rename Change registered library name

Comments

@mathieucarbou
Copy link
Contributor

Library repository URL

https://github.com/mathieucarbou/ESPAsyncWebServer

@mathieucarbou mathieucarbou added the topic: rename Change registered library name label Sep 30, 2024
@mathieucarbou
Copy link
Contributor Author

ESP Async WebServer => ESPAsyncWebServer

To comply with Arduino library name conventions.

Important notes:

@per1234
Copy link
Contributor

per1234 commented Oct 5, 2024

Hi @mathieucarbou. As you noted, the name "ESPAsyncWebServer" has already been claimed so we can not change your library's registered name to that.

You will need to select a unique name:

  1. Change the name property in your library's library.properties metadata file to the unique name.
  2. Create a new release or tag in the library repository.
  3. Comment here to let us know we can proceed with the renaming.

Or if you decide you prefer to stick with the current registered name "ESP Async WebServer", you can simply close this issue.

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Oct 5, 2024
@mathieucarbou
Copy link
Contributor Author

I think for now maybe the best option is for me to change it with:

name=ESP Async WebServer
includes=ESPAsyncWebServer.h

and issue a new release.

Everywhere in the project ESPAsyncWebServer will be used, but ESP Async WebServer will only be used for the Arduino Registry name then.

@per1234 per1234 added conclusion: invalid Issue/PR not valid and removed status: waiting for information More information must be provided before work can proceed labels Oct 5, 2024
@per1234 per1234 self-assigned this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: rename Change registered library name
Projects
None yet
Development

No branches or pull requests

2 participants