Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make repository methods protected to allow for subclassing #397

Closed
eldamir opened this issue May 9, 2024 · 2 comments · Fixed by #398
Closed

Make repository methods protected to allow for subclassing #397

eldamir opened this issue May 9, 2024 · 2 comments · Fixed by #398
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@eldamir
Copy link
Contributor

eldamir commented May 9, 2024

In order to customise and extend the behaviour of the Repository (RepositoryBase), its methods and fields should be protected rather than private
@eldamir eldamir mentioned this issue May 9, 2024
Open
@ardalis ardalis added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 9, 2024
@ardalis
Copy link
Owner

ardalis commented May 9, 2024

Yours if you want to claim it @eldamir

Thanks!

@eldamir eldamir mentioned this issue May 9, 2024
Merged
@eldamir
Copy link
Contributor Author

eldamir commented May 9, 2024

There ya go #398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

397 make fields and methods protected eldamir/Specification
2 participants
@ardalis @eldamir