Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpect Dependencie: Cannot find module 'axios' #69

Closed
machao7 opened this issue Jul 26, 2022 · 1 comment · Fixed by #74
Closed

Unexpect Dependencie: Cannot find module 'axios' #69

machao7 opened this issue Jul 26, 2022 · 1 comment · Fixed by #74
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@machao7
Copy link

machao7 commented Jul 26, 2022

i think http/https module will be a better choice for node env.
In my node project, axios is not a dependency. When I install kutt, I got the error which in the title.

@ardalanamini ardalanamini added the enhancement New feature or request label Aug 5, 2022
@ardalanamini ardalanamini self-assigned this Aug 5, 2022
@ardalanamini
Copy link
Owner

@machao7 Thanks for the enhancement request.
Currently axios is a peer-dependency, after reading this issue, initially, I was thinking about using fetch instead, but its support in Node.js is only added in the latest versions and not backward compatible, so the only relatively clean solution I can think of at the moment is using the package.json imports using HTTP(S) module in node and fetch in other environments to completely remove the need for any dependencies, what do you think about this solution? 🤔

@ardalanamini ardalanamini added this to the v3.0.0 milestone Aug 5, 2022
@ardalanamini ardalanamini linked a pull request Aug 15, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants