Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth: Incorrect logic in handleWindowClose #561

Open
Danziger opened this issue Dec 4, 2024 · 0 comments
Open

Auth: Incorrect logic in handleWindowClose #561

Danziger opened this issue Dec 4, 2024 · 0 comments
Labels
good first issue Good for newcomers ready for dev

Comments

@Danziger
Copy link
Contributor

Danziger commented Dec 4, 2024

Instead of checking if all windows are closed, it should be checking if all connected apps are closed.

This is marked in the code with the following TODO: // TODO: Maybe we should be counting connected apps instead?
@Danziger Danziger mentioned this issue Dec 4, 2024
Merged
@Danziger Danziger added the good first issue Good for newcomers label Dec 4, 2024
@Danziger Danziger changed the title Incorrect logic in handleWindowClose Auth: Incorrect logic in handleWindowClose Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers ready for dev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Danziger