Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth popup & permission/authorization issues #550

Open
Danziger opened this issue Nov 22, 2024 · 0 comments
Open

Auth popup & permission/authorization issues #550

Danziger opened this issue Nov 22, 2024 · 0 comments

Comments

@Danziger
Copy link
Contributor

Danziger commented Nov 22, 2024

UI issues:

  • The SignDataItem page is only used for token transfers, while the Sign page is used for both sign() and signDataItem(), but the SignDataItem page doesn't show amounts while the Sign one does.
  • The BulkSignDataItem page doesn't show amounts like the Sign or SignDataItem do, not even when opening each individual DataItem.
  • dispatch() will re-request permissions if the upload to Turbo fails. While that's ok, it would be better if either the first AuthRequest item reflects that it failed (despite being accepted by the user) or, even better, the same item is re-used, showing/explaining that it failed and re-requesting permissions to try to post the tx directly.

Logic (permission/authorization) issues:

Other issues:

  • wallet_names.background.ts throws a "No wallets added" error but doesn't open the Welcome page.
@Danziger Danziger changed the title Fix Auth popup issues Auth popup & permission/authorization issues Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant