Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use previous reward address when sending node transaction #909

Closed
Neylix opened this issue Feb 20, 2023 · 0 comments · Fixed by #916
Closed

Use previous reward address when sending node transaction #909

Neylix opened this issue Feb 20, 2023 · 0 comments · Fixed by #916
Assignees
Labels
bootstrap bug Something isn't working

Comments

@Neylix
Copy link
Member

Neylix commented Feb 20, 2023

Describe the problem you discovered

When a node bootstrap, it may send a new node transaction. But if the node was already known by the network and its reward has been changed, the bootstrap node transaction send the one by default (env variable or the address of the node chain).
It should take the last reward address known by the network.

Describe the solution you'd like

When the node bootstrap (module Bootstrap) before sending the new node transaction (in first_initialization and update_node function) it should get the last reward address of the node if it exists

@Neylix Neylix added bug Something isn't working bootstrap labels Feb 20, 2023
@samuelmanzanera samuelmanzanera moved this to Todo 🚩 in Dev Board Feb 21, 2023
@samuelmanzanera samuelmanzanera moved this from Todo 🚩 to In Progress 🚧 in Dev Board Feb 27, 2023
@samuelmanzanera samuelmanzanera self-assigned this Feb 27, 2023
@samuelmanzanera samuelmanzanera moved this from In Progress 🚧 to Review 💬 in Dev Board Feb 27, 2023
@github-project-automation github-project-automation bot moved this from Review 💬 to Done 🍻 in Dev Board Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootstrap bug Something isn't working
Projects
Status: Done 🍻
Development

Successfully merging a pull request may close this issue.

2 participants