Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with case sensitivity of asset names on AEWeb #1049

Closed
redDwarf03 opened this issue May 24, 2023 · 1 comment · Fixed by #1580
Closed

Issue with case sensitivity of asset names on AEWeb #1049

redDwarf03 opened this issue May 24, 2023 · 1 comment · Fixed by #1580
Assignees
@wassimans
Labels
API Involve API facing user bug Something isn't working good first issue Good for newcomers

Comments

@redDwarf03
Copy link
Member

redDwarf03 commented May 24, 2023 •
edited by samuelmanzanera
Loading

Describe the problem you discovered

Currently, asset names are case sensitive, which creates inconvenience and discomfort for users.

For instance, if I have an HTML page with the following code:
<img src="assets/images/logo.png" alt="logo" style="width: 100px">

And my asset is named "Logo.png" with an uppercase "L," AEWebsite fails to display the image correctly.

Describe the solution you'd like

No response

Epic

#1062
@redDwarf03 redDwarf03 added the bug Something isn't working label May 24, 2023
@redDwarf03 redDwarf03 changed the title AEWEB - Strict url issue Issue with case sensitivity of asset names on AEWebsite May 24, 2023
@redDwarf03 redDwarf03 changed the title Issue with case sensitivity of asset names on AEWebsite Issue with case sensitivity of asset names on AEWeb May 24, 2023
@samuelmanzanera samuelmanzanera added this to the 1.3.0 milestone Jun 19, 2023
@samuelmanzanera samuelmanzanera added API Involve API facing user good first issue Good for newcomers labels Jun 19, 2023
@samuelmanzanera samuelmanzanera removed this from the 1.3.0 milestone Jun 28, 2023
@wassimans wassimans mentioned this issue Oct 18, 2024
Merged
@wassimans
Copy link

The issue is addressed in PR #1580.

I’ve implemented a fix that addresses the case sensitivity issue for asset paths by normalizing the file paths to lowercase. The fix includes tests for various cases such as mixed cases and file extensions.
The solution is now available in PR #1580 for review.

@wassimans wassimans self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wassimans wassimans

Labels
API Involve API facing user bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix aeweb case sensitivity for asset names wassimans/archethic-node
3 participants
@wassimans @samuelmanzanera @redDwarf03