Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the keychain's service creation step in the global process #9

Open
redDwarf03 opened this issue May 16, 2023 · 0 comments
Open
Assignees

Comments

@redDwarf03
Copy link
Member

Is your feature request related to a problem?

Currently, the service is created at the beginning of the process when a new website is created.
If the user decides not to pay the fee (or cannot), the site is not deployed but the service still exists

Describe the solution you'd like

2 possibilities

  • Make a rollback by updating the keychain without the service (which requires a new validation on the wallet side)
  • Create the service after the validation of global fees by the user.

Additional context

The second solution is blocked by a check on the address derivation and keypair methods which verify that the service exists in the keychain. It is therefore necessary either to put a parameter to exclude this control in certain cases (this also requires to provide the derivation path instead of the service name) or to manage the new keychain service on the wallet side in memory in a session.

@redDwarf03 redDwarf03 self-assigned this Jun 1, 2023
@redDwarf03 redDwarf03 moved this to Todo 🚩 in Dev Board Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo 🚩
Development

No branches or pull requests

1 participant