Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python wheel] Currently, NML support is disabled. #1792

Closed
4 tasks
brenthuisman opened this issue Dec 16, 2021 · 0 comments · Fixed by #1784
Closed
4 tasks

[Python wheel] Currently, NML support is disabled. #1792

brenthuisman opened this issue Dec 16, 2021 · 0 comments · Fixed by #1784
Assignees
Labels
bug packaging Installation from source and production of distro packages, python packages. python
Milestone

Comments

@brenthuisman
Copy link
Contributor

brenthuisman commented Dec 16, 2021

The binary wheels for v0.5.2 were built without NeuroML support. The precise reason is still unclear, because for this reason NML support was set to enabled by default, which I locally verified. It explains why the missing libxml2 error started showing up in #1784.

Solution:

  • Change build to actually enable NML support.
  • Add testing to the wheel workflow (e.g. run scripts/run_python_examples.sh).
  • Modify config() to show whether or not nml was compiled in.
  • Add the script and documentation for local testing of the manylinux wheel builds to the repo.
@brenthuisman brenthuisman added bug python packaging Installation from source and production of distro packages, python packages. labels Dec 16, 2021
@brenthuisman brenthuisman added this to the v0.6 milestone Dec 16, 2021
@brenthuisman brenthuisman self-assigned this Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug packaging Installation from source and production of distro packages, python packages. python
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant