Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page tokens generated on first use are not sent back to the client #145

Closed
forgedhallpass opened this issue Sep 14, 2020 · 1 comment
Closed

Comments

@forgedhallpass
Copy link
Collaborator

When using the Token-per-page option with AJAX and without token pre-creation (no protected pages are being configured), the solution validates the request with the master token, then generates a new page token on first access of new pages/endpoints, but does not send back the the value to the UI. This behavior leads to false positive CSRF attack attempts and makes the application unusable.

Proposed solution:
Send back the newly generated page token in the response of the request. The JavaScript logic should intercept all XHR requests, look for the specific header and should update the token value associated to the specific page/endpoint if present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant